Skip to content

[Fix-8633][UI Next][V1.0.0-Alpha] Work out this issue to edit the process definition when clicking the edit button. - #8705

Merged
songjianet merged 1 commit into
apache:devfrom
calvinjiang:f-edit-process-definition
Mar 5, 2022
Merged

[Fix-8633][UI Next][V1.0.0-Alpha] Work out this issue to edit the process definition when clicking the edit button.#8705
songjianet merged 1 commit into
apache:devfrom
calvinjiang:f-edit-process-definition

Conversation

@calvinjiang

Copy link
Copy Markdown
Contributor

Purpose of the pull request

This PR will close #8633 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.
    After click the edit button , the page of process dag can display.
    image

@songjianet songjianet self-assigned this Mar 5, 2022
@songjianet songjianet added bug Something isn't working UI ui and front end related labels Mar 5, 2022
@songjianet songjianet assigned calvinjiang and unassigned songjianet Mar 5, 2022
@devosend

devosend commented Mar 5, 2022

Copy link
Copy Markdown
Contributor

LGTM

@songjianet songjianet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #8705 (0b463c7) into dev (6dc4be5) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8705      +/-   ##
============================================
- Coverage     45.31%   45.30%   -0.02%     
+ Complexity     4075     4074       -1     
============================================
  Files           700      700              
  Lines         27050    27050              
  Branches       2894     2894              
============================================
- Hits          12258    12254       -4     
- Misses        13636    13643       +7     
+ Partials       1156     1153       -3     
Impacted Files Coverage Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.81% <0.00%> (+2.11%) ⬆️
...lphinscheduler/rpc/common/AbstractRpcCallBack.java 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc4be5...0b463c7. Read the comment docs.

@sonarqubecloud

sonarqubecloud Bot commented Mar 5, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@songjianet songjianet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet
songjianet merged commit 304d7a7 into apache:dev Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][UI Next][V1.0.0-Alpha] Workflow definition click to modify does not get the expected response

4 participants