Fix macOS thirdparty builds and Docker release gating - #405
Merged
morningman merged 2 commits intoAug 6, 2026
Conversation
hello-stephen
marked this pull request as ready for review
August 6, 2026 09:32
morningman
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsan_interface_atomic.hfrom the GCC GitHub mirror when gcc.gnu.org rate-limits hosted runners, verifying the expected MD5 before replacementRoot cause
Scheduled run https://github.com/apache/doris-thirdparty/actions/runs/31019437034 built and uploaded both Linux packages, but both macOS jobs failed while configuring Arrow 24:
Because
update-dockerrequired the aggregate matrix result to be successful, those macOS failures skipped Docker publication even though the required Linux x86_64 package was available. The failure handler also replaced the release note without retainingDoris Version, causing later scheduled runs to detect an empty previous version and repeat the full build.During runtime validation, gcc.gnu.org also rate-limited GitHub hosted runners and left
tsan_interface_atomic.hempty in the cached source archive. The fallback repairs only an invalid copy and verifies MD5d72679bea167d6a513d959f5abd149dcbefore replacing it.Safety
Docker publication now fails closed unless
installed/_doris_thirdparty_commit_indoris-thirdparty-prebuilt-linux-x86_64.tar.xzexactly matches the commit exported by the prerelease job. A cancelled matrix still prevents Docker publication.Validation
Static and package checks:
actionlint -shellcheck= .github/workflows/build.ymlgit diff --check771548ed2abae17f3fd28dcfa572ba3fe9f970652a72c36c2e1aafdee93a234eagainst Kitware's release checksum listd72679bea167d6a513d959f5abd149dcFull runtime validation:
04385bd40c223d3e1b5cd4753ec95b284c5b29edcmake version 3.25.35baf0455f1dba3e43feda73e1c0303ab0369eaf0sha256:6213c6455b08b4bda5f29922359732f3873023a68f6f4e8721d04c704e2b2c0fsha256:d869af782f9bd1912c1d489db216549615df80feebd152976cf3c661721fc82e