Skip to content

[fix](yearweek) fixed the yearweek result error when mode is set to 1#12234

Merged
yiguolei merged 1 commit intoapache:masterfrom
luozenglin:year_week_fix
Sep 1, 2022
Merged

[fix](yearweek) fixed the yearweek result error when mode is set to 1#12234
yiguolei merged 1 commit intoapache:masterfrom
luozenglin:year_week_fix

Conversation

@luozenglin
Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #12233

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Copy Markdown
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 31, 2022
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 65051d6 into apache:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] When mode is set to 1, the result of yearweek is wrong

3 participants