Skip to content

[fix](yearweek) fixed the yearweek result error when mode is set to 1 #12234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Sep 1, 2022
Merged

[fix](yearweek) fixed the yearweek result error when mode is set to 1 #12234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/vec/runtime/vdatetime_value.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ uint32_t VecDateTimeValue::year_week(uint8_t mode) const {
// not covered by year_week_table, calculate at runtime
uint32_t year = 0;
// The range of the week in the year_week is 1-53, so the mode WEEK_YEAR is always true.
uint8_t week = calc_week(*this, mode | 2, &year);
uint8_t week = calc_week(*this, mode | 2, &year, true);
// When the mode WEEK_FIRST_WEEKDAY is not set,
// the week in which the last three days of the year fall may belong to the following year.
if (week == 53 && day() >= 29 && !(mode & 4)) {
Expand Down
24 changes: 24 additions & 0 deletions regression-test/data/query_p0/sql_functions/datetime_functions/test_date_function.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,30 @@ February
-- !sql --
202026

-- !sql --
198912

-- !sql --
198912

-- !sql --
198912

-- !sql --
198912

-- !sql --
198912

-- !sql --
198912

-- !sql --
198912

-- !sql --
198912

-- !sql --
200

Expand Down
8 changes: 8 additions & 0 deletions regression-test/suites/query_p0/sql_functions/datetime_functions/test_date_function.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,14 @@ suite("test_date_function") {
// YEARWEEK
qt_sql """ select yearweek('2021-1-1') """
qt_sql """ select yearweek('2020-7-1') """
qt_sql """ select yearweek('1989-03-21', 0) """
qt_sql """ select yearweek('1989-03-21', 1) """
qt_sql """ select yearweek('1989-03-21', 2) """
qt_sql """ select yearweek('1989-03-21', 3) """
qt_sql """ select yearweek('1989-03-21', 4) """
qt_sql """ select yearweek('1989-03-21', 5) """
qt_sql """ select yearweek('1989-03-21', 6) """
qt_sql """ select yearweek('1989-03-21', 7) """

qt_sql """ select count(*) from (select * from numbers("200")) tmp1 WHERE 0 <= UNIX_TIMESTAMP(); """

Expand Down