[opt](nereids) compare str literal as date literal to compute selectivity#35610
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
morrySnow
reviewed
May 29, 2024
TPC-H: Total hot run time: 41558 ms |
TPC-DS: Total hot run time: 172489 ms |
ClickBench: Total hot run time: 30.47 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 42253 ms |
morrySnow
approved these changes
May 30, 2024
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 171106 ms |
ClickBench: Total hot run time: 30.65 s |
starocean999
approved these changes
May 30, 2024
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
May 30, 2024
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
May 30, 2024
yiguolei
pushed a commit
that referenced
this pull request
May 30, 2024
…vity (#35610) this pr improves #34542, when the real data type is date-like type. Some users are likely to define date(datetime) column as Varchar type. when estimating the selectivity of predicate like A>'2020-01-01', if nereids regards A and '2020-01-01' as date type, the sel is more accurate than that as string type.
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
May 31, 2024
dataroaring
pushed a commit
that referenced
this pull request
May 31, 2024
…vity (#35610) this pr improves #34542, when the real data type is date-like type. Some users are likely to define date(datetime) column as Varchar type. when estimating the selectivity of predicate like A>'2020-01-01', if nereids regards A and '2020-01-01' as date type, the sel is more accurate than that as string type.
xiaokang
pushed a commit
that referenced
this pull request
Jun 2, 2024
… (#35667) Some users are likely to define date(datetime) column as Varchar type. when estimating the selectivity of predicate like A>'2020-01-01', if nereids regards A and '2020-01-01' as date type, the sel is more accurate than that as string type.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…apache#34542 (apache#35667) Some users are likely to define date(datetime) column as Varchar type. when estimating the selectivity of predicate like A>'2020-01-01', if nereids regards A and '2020-01-01' as date type, the sel is more accurate than that as string type.
16 tasks
englefly
added a commit
that referenced
this pull request
Aug 28, 2025
### What problem does this PR solve? in #35610, we try to estimate string column as date column to improve estimation accuracy, since many users define a date value column as string. after estimation, we need to convert min/maxExpr from date literal to string literal. we checked minExpr != null && maxExpr!=null. But after #54035, the column stats may be minExpr != null but maxExpr == null. and this leads to NPE.
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…vity (apache#35610) this pr improves apache#34542, when the real data type is date-like type. Some users are likely to define date(datetime) column as Varchar type. when estimating the selectivity of predicate like A>'2020-01-01', if nereids regards A and '2020-01-01' as date type, the sel is more accurate than that as string type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr improves #34542, when the real data type is date-like type.
Some users are likely to define date(datetime) column as Varchar type.
when estimating the selectivity of predicate like A>'2020-01-01', if nereids regards A and '2020-01-01' as date type, the sel is more accurate than that as string type.