Skip to content

[fix](restore) Remove the sqlMode from the view signature #40615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
w41ter merged 1 commit into from
Sep 11, 2024
Merged

[fix](restore) Remove the sqlMode from the view signature #40615

w41ter merged 1 commit into from
Sep 11, 2024

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented Sep 10, 2024

To keep compatible with the old version, without sqlMode, if the signature of views are the same, we should have the same sqlMode. (since the sqlMode doesn't affect the parsing of inlineViewDef, otherwise the parsing will fail)

@doris-robot
Copy link

doris-robot commented Sep 10, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Contributor Author

w41ter commented Sep 10, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 10, 2024

TPC-H: Total hot run time: 38334 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1390ba076dc461f4e7b101b43fec0c05d15d5bca, data reload: false

------ Round 1 ----------------------------------
q1	17608	4554	4315	4315
q2	2022	211	187	187
q3	11594	934	1074	934
q4	10496	822	676	676
q5	7790	2863	2823	2823
q6	226	138	135	135
q7	958	617	603	603
q8	9536	2112	2110	2110
q9	7259	6592	6594	6592
q10	7025	2260	2249	2249
q11	512	268	256	256
q12	406	232	245	232
q13	18836	3205	3153	3153
q14	270	235	237	235
q15	544	509	487	487
q16	545	435	434	434
q17	1005	657	689	657
q18	7421	6846	6953	6846
q19	1397	997	1058	997
q20	706	339	331	331
q21	3953	3081	3072	3072
q22	1117	1018	1010	1010
Total cold run time: 111226 ms
Total hot run time: 38334 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4428	4302	4279	4279
q2	385	280	283	280
q3	2962	2695	2703	2695
q4	1975	1611	1680	1611
q5	5749	5739	5814	5739
q6	241	143	142	142
q7	2252	1875	1859	1859
q8	3323	3488	3552	3488
q9	8963	8925	8896	8896
q10	3672	3355	3403	3355
q11	606	498	496	496
q12	847	664	647	647
q13	14068	3224	3379	3224
q14	333	274	280	274
q15	556	488	477	477
q16	554	502	522	502
q17	1825	1534	1577	1534
q18	8240	7982	8074	7982
q19	1774	1542	1602	1542
q20	2164	1905	1926	1905
q21	5803	5627	5468	5468
q22	1130	1017	1039	1017
Total cold run time: 71850 ms
Total hot run time: 57412 ms

@doris-robot
Copy link

doris-robot commented Sep 10, 2024

TPC-DS: Total hot run time: 197692 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1390ba076dc461f4e7b101b43fec0c05d15d5bca, data reload: false

query1	1263	899	923	899
query2	6447	1900	1928	1900
query3	10603	4074	3928	3928
query4	59748	29034	23274	23274
query5	5003	508	490	490
query6	388	170	154	154
query7	5633	299	288	288
query8	309	214	213	213
query9	7624	2478	2534	2478
query10	423	281	269	269
query11	16587	15409	15673	15409
query12	156	106	101	101
query13	1435	397	383	383
query14	10731	6989	6876	6876
query15	212	186	180	180
query16	6809	445	481	445
query17	1080	586	555	555
query18	1528	314	307	307
query19	206	161	155	155
query20	121	111	120	111
query21	205	109	111	109
query22	4750	4664	4504	4504
query23	34435	33710	33410	33410
query24	6023	2998	2881	2881
query25	512	411	410	410
query26	607	155	158	155
query27	1606	276	283	276
query28	3694	2034	2023	2023
query29	660	435	445	435
query30	237	154	160	154
query31	908	782	778	778
query32	73	52	53	52
query33	440	304	287	287
query34	898	474	463	463
query35	834	735	728	728
query36	1092	921	960	921
query37	147	91	85	85
query38	4093	3863	3923	3863
query39	1455	1403	1390	1390
query40	194	114	114	114
query41	46	44	44	44
query42	118	98	97	97
query43	520	479	473	473
query44	1138	761	749	749
query45	206	169	167	167
query46	1094	766	735	735
query47	1910	1792	1771	1771
query48	383	300	304	300
query49	783	452	463	452
query50	817	417	425	417
query51	7104	6830	6962	6830
query52	103	88	88	88
query53	252	187	178	178
query54	571	462	466	462
query55	77	74	76	74
query56	277	263	258	258
query57	1211	1102	1078	1078
query58	252	258	239	239
query59	3066	3104	2899	2899
query60	302	277	277	277
query61	129	118	123	118
query62	761	667	667	667
query63	224	193	191	191
query64	1469	751	799	751
query65	3210	3138	3181	3138
query66	680	333	333	333
query67	15756	15311	15421	15311
query68	1869	855	863	855
query69	434	319	316	316
query70	1183	1178	1177	1177
query71	347	340	338	338
query72	5275	3577	3435	3435
query73	583	584	574	574
query74	9053	8959	8883	8883
query75	3048	2937	2981	2937
query76	979	834	840	834
query77	512	429	410	410
query78	9599	9244	9224	9224
query79	898	890	854	854
query80	823	815	784	784
query81	469	261	258	258
query82	266	260	264	260
query83	188	188	191	188
query84	232	104	104	104
query85	619	429	388	388
query86	308	306	324	306
query87	4385	4380	4344	4344
query88	4316	4064	4073	4064
query89	367	361	372	361
query90	1544	309	305	305
query91	122	122	127	122
query92	78	75	75	75
query93	921	911	913	911
query94	556	352	378	352
query95	417	420	417	417
query96	465	465	467	465
query97	3151	3097	3127	3097
query98	239	222	225	222
query99	1451	1282	1342	1282
Total cold run time: 296325 ms
Total hot run time: 197692 ms

@doris-robot
Copy link

doris-robot commented Sep 10, 2024

ClickBench: Total hot run time: 32 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1390ba076dc461f4e7b101b43fec0c05d15d5bca, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.08	0.09
query5	0.52	0.50	0.51
query6	1.13	0.76	0.73
query7	0.02	0.02	0.01
query8	0.06	0.05	0.04
query9	0.54	0.48	0.47
query10	0.55	0.56	0.53
query11	0.15	0.11	0.12
query12	0.15	0.13	0.12
query13	0.61	0.59	0.59
query14	1.41	1.42	1.36
query15	0.84	0.82	0.82
query16	0.36	0.40	0.36
query17	1.02	1.05	1.05
query18	0.21	0.21	0.20
query19	1.94	1.77	1.70
query20	0.01	0.01	0.01
query21	15.43	0.77	0.78
query22	4.06	6.33	2.32
query23	18.31	1.38	1.36
query24	2.08	0.24	0.21
query25	0.15	0.08	0.08
query26	0.26	0.18	0.17
query27	0.07	0.08	0.07
query28	13.27	1.01	1.00
query29	12.65	3.37	3.33
query30	0.26	0.07	0.05
query31	2.87	0.41	0.39
query32	3.25	0.48	0.48
query33	2.98	3.02	3.10
query34	17.16	4.39	4.44
query35	4.54	4.49	4.48
query36	0.66	0.47	0.48
query37	0.18	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.12	0.14
query41	0.10	0.05	0.06
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.28 s
Total hot run time: 32 s

dataroaring
dataroaring approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024

PR approved by anyone and no changes requested.

@w41ter w41ter merged commit d77d74a into apache:master Sep 11, 2024
@w41ter w41ter deleted the remove_sql_mode_from_signature branch September 11, 2024 11:34
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Sep 23, 2024
@w41ter
[fix](restore) Remove the sqlMode from the view signature (apache#40615)
457fc6d 
To keep compatible with the old version, without sqlMode, if the
signature of views are the same, we should have the same sqlMode. (since
the sqlMode doesn't affect the parsing of inlineViewDef, otherwise the
parsing will fail)
@w41ter w41ter mentioned this pull request Sep 23, 2024
Merged
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Sep 23, 2024
@w41ter
[fix](restore) Remove the sqlMode from the view signature (apache#40615)
9529d86 
To keep compatible with the old version, without sqlMode, if the
signature of views are the same, we should have the same sqlMode. (since
the sqlMode doesn't affect the parsing of inlineViewDef, otherwise the
parsing will fail)
@w41ter w41ter mentioned this pull request Sep 23, 2024
Merged
w41ter added a commit that referenced this pull request Sep 23, 2024
@w41ter
[fix](restore) Remove the sqlMode from the view signature #40615 (#41110
059f822 
)

cherry pick from #40615
w41ter added a commit that referenced this pull request Sep 23, 2024
@w41ter
[fix](restore) Remove the sqlMode from the view signature #40615 (#41105
61aa9cb 
)

cherry pick from #40615
@xiaokang xiaokang added dev/2.0.15-merged and removed approved Indicates a PR has been approved by one committer. dev/2.0.16-merged labels Sep 25, 2024
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@w41ter @dataroaring
[fix](restore) Remove the sqlMode from the view signature (#40615)
b3f28cd 
To keep compatible with the old version, without sqlMode, if the
signature of views are the same, we should have the same sqlMode. (since
the sqlMode doesn't affect the parsing of inlineViewDef, otherwise the
parsing will fail)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

dev/2.0.15-merged dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@w41ter @doris-robot @gavinchou @dataroaring @xiaokang