Skip to content

[fix](restore) Remove the sqlMode from the view signature #40615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w41ter merged 1 commit into from
Sep 11, 2024
Merged

[fix](restore) Remove the sqlMode from the view signature #40615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/catalog/View.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,14 @@ public String getSignature(int signatureVersion) {
sb.append(type);
sb.append(Util.getSchemaSignatureString(fullSchema));
sb.append(inlineViewDef);
sb.append(sqlMode);

// ATTN: sqlMode is missing when persist view, so we should not append it here.
//
// To keep compatible with the old version, without sqlMode, if the signature of views
// are the same, we think the should has the same sqlMode. (since the sqlMode doesn't
// effect the parsing of inlineViewDef, otherwise the parsing will fail),
//
// sb.append(sqlMode);
String md5 = DigestUtils.md5Hex(sb.toString());
if (LOG.isDebugEnabled()) {
LOG.debug("get signature of view {}: {}. signature string: {}", name, md5, sb.toString());
Expand Down