Skip to content

[fix](nereids)modify split_part function to fold to null literal with correct data type #41109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 23, 2024
Merged

[fix](nereids)modify split_part function to fold to null literal with correct data type #41109

morrySnow merged 1 commit into from
Sep 23, 2024

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Sep 23, 2024

…

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

doris-robot commented Sep 23, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

starocean999 commented Sep 23, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Sep 23, 2024

TPC-H: Total hot run time: 41668 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 577e5eec736390a93b480686a6866447c8850d4f, data reload: false

------ Round 1 ----------------------------------
q1	18110	7466	7263	7263
q2	2556	163	172	163
q3	11686	1156	1172	1156
q4	10360	737	796	737
q5	8191	3160	3142	3142
q6	239	156	155	155
q7	1014	634	628	628
q8	9485	2031	2051	2031
q9	6863	6414	6388	6388
q10	6983	2244	2289	2244
q11	424	246	254	246
q12	402	223	219	219
q13	17783	2990	2968	2968
q14	241	216	216	216
q15	579	529	523	523
q16	664	610	611	610
q17	960	776	839	776
q18	7308	6735	6643	6643
q19	1401	1038	1124	1038
q20	574	293	274	274
q21	3967	3241	3242	3241
q22	1113	1036	1007	1007
Total cold run time: 110903 ms
Total hot run time: 41668 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7233	7231	7184	7184
q2	331	227	226	226
q3	2886	2764	2728	2728
q4	1923	1695	1690	1690
q5	5369	5405	5390	5390
q6	226	147	142	142
q7	2110	1719	1698	1698
q8	3158	3281	3308	3281
q9	8369	8434	8469	8434
q10	3380	3340	3317	3317
q11	572	475	465	465
q12	793	564	579	564
q13	6545	3043	2973	2973
q14	299	251	269	251
q15	558	511	505	505
q16	715	674	679	674
q17	1767	1553	1531	1531
q18	7633	7349	7455	7349
q19	1669	1530	1591	1530
q20	2044	1816	1811	1811
q21	5289	5175	5120	5120
q22	1123	1030	997	997
Total cold run time: 63992 ms
Total hot run time: 57860 ms

@doris-robot
Copy link

doris-robot commented Sep 23, 2024

TPC-DS: Total hot run time: 190527 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 577e5eec736390a93b480686a6866447c8850d4f, data reload: false

query1	984	368	372	368
query2	6532	2157	2040	2040
query3	6709	211	219	211
query4	34105	23448	23395	23395
query5	4296	473	472	472
query6	258	177	163	163
query7	4625	311	321	311
query8	281	221	247	221
query9	9634	2651	2648	2648
query10	445	278	280	278
query11	18027	15215	15128	15128
query12	154	98	98	98
query13	1621	412	416	412
query14	10482	6952	7264	6952
query15	252	168	183	168
query16	8020	443	458	443
query17	1667	574	556	556
query18	2130	304	310	304
query19	376	154	157	154
query20	117	106	105	105
query21	216	107	106	106
query22	4496	4204	4232	4204
query23	34470	33747	33832	33747
query24	11189	2917	2828	2828
query25	667	398	420	398
query26	1394	159	159	159
query27	2804	294	287	287
query28	7912	2458	2448	2448
query29	904	442	432	432
query30	327	164	156	156
query31	1010	795	794	794
query32	104	58	59	58
query33	786	300	302	300
query34	950	483	485	483
query35	881	752	730	730
query36	1093	950	926	926
query37	153	94	88	88
query38	4041	3883	3955	3883
query39	1473	1438	1520	1438
query40	281	100	98	98
query41	52	48	48	48
query42	116	96	99	96
query43	536	484	495	484
query44	1278	839	810	810
query45	195	167	170	167
query46	1121	752	809	752
query47	1866	1818	1825	1818
query48	460	364	361	361
query49	1141	420	409	409
query50	809	407	410	407
query51	7116	6864	7053	6864
query52	100	86	88	86
query53	259	185	186	185
query54	1361	463	455	455
query55	80	80	81	80
query56	307	270	258	258
query57	1219	1094	1119	1094
query58	255	235	238	235
query59	3053	3106	3125	3106
query60	305	286	292	286
query61	147	108	103	103
query62	852	651	659	651
query63	210	183	185	183
query64	5187	638	615	615
query65	3276	3209	3164	3164
query66	1433	309	297	297
query67	16091	15575	15584	15575
query68	5007	573	564	564
query69	464	293	291	291
query70	1220	1066	1152	1066
query71	452	275	268	268
query72	6430	3993	4084	3993
query73	757	331	332	331
query74	9924	8986	8978	8978
query75	3410	2673	2625	2625
query76	2942	868	881	868
query77	465	285	285	285
query78	9848	9430	9326	9326
query79	2185	542	547	542
query80	1089	446	439	439
query81	569	242	239	239
query82	703	144	141	141
query83	248	140	139	139
query84	242	86	73	73
query85	1488	298	300	298
query86	449	302	288	288
query87	4486	4316	4328	4316
query88	3707	2344	2317	2317
query89	394	282	279	279
query90	2001	192	193	192
query91	174	164	159	159
query92	70	47	48	47
query93	1427	547	539	539
query94	1007	303	279	279
query95	351	256	250	250
query96	600	274	281	274
query97	3251	3059	3096	3059
query98	211	199	206	199
query99	1585	1305	1284	1284
Total cold run time: 301847 ms
Total hot run time: 190527 ms

@doris-robot
Copy link

doris-robot commented Sep 23, 2024

ClickBench: Total hot run time: 32.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 577e5eec736390a93b480686a6866447c8850d4f, data reload: false

query1	0.04	0.04	0.04
query2	0.06	0.02	0.03
query3	0.22	0.06	0.06
query4	1.65	0.10	0.10
query5	0.51	0.49	0.50
query6	1.15	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.49	0.50
query10	0.57	0.56	0.54
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.59
query14	2.89	2.94	2.93
query15	0.88	0.82	0.80
query16	0.39	0.38	0.36
query17	1.04	0.97	1.01
query18	0.22	0.20	0.21
query19	1.91	1.81	1.98
query20	0.01	0.01	0.01
query21	15.35	0.61	0.57
query22	2.77	2.23	1.44
query23	17.26	0.80	0.80
query24	2.75	1.10	1.03
query25	0.24	0.16	0.13
query26	0.33	0.13	0.13
query27	0.04	0.03	0.04
query28	10.94	1.10	1.07
query29	12.57	3.24	3.27
query30	0.23	0.06	0.05
query31	2.90	0.38	0.37
query32	3.31	0.46	0.46
query33	3.00	3.02	3.03
query34	16.79	4.34	4.36
query35	4.42	4.43	4.42
query36	0.69	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.12	0.13
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.1 s
Total hot run time: 32.27 s

@starocean999 starocean999 marked this pull request as ready for review September 23, 2024 06:33
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit c38938d into apache:master Sep 23, 2024
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@starocean999 @dataroaring
[fix](nereids)modify split_part function to fold to null literal with…
56cb52f 
… correct data type (#41109)
@starocean999 starocean999 mentioned this pull request Oct 18, 2024
Merged
yiguolei pushed a commit that referenced this pull request Oct 18, 2024
@starocean999
[fix](nereids)modify split_part function to fold to null literal with…
4edfbb5 
… correct data type (#42100)

pick from master #41109

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 26, 2025
fix(nereids): modify split_part function to fold to null literal with…
56313f7 
… correct data type (apache#42100)

pick from master apache#41109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@starocean999 @doris-robot @feiniaofeiafei @morrySnow