Skip to content

[fix](nereids)modify split_part function to fold to null literal with correct data type #41109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Sep 23, 2024
Merged

[fix](nereids)modify split_part function to fold to null literal with correct data type #41109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ava/org/apache/doris/nereids/trees/expressions/functions/executable/StringArithmetic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ public static Expression splitPart(StringLikeLiteral first, StringLikeLiteral ch
return castStringLikeLiteral(first, "");
}
}
return new NullLiteral();
return new NullLiteral(first.getDataType());
} else if (number.getValue() < 0) {
StringBuilder result = new StringBuilder(parts[Math.abs(number.getValue()) - 1]);
return castStringLikeLiteral(first, result.reverse().toString());
Expand Down
5 changes: 5 additions & 0 deletions regression-test/suites/nereids_p0/sql_functions/string_functions/test_split_part.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,9 @@ suite("test_split_part") {
}

qt_1 "select split_part(k8, '1', 1), k8, split_part(concat(k8, '12'), '1', 1) from nereids_test_query_db.test order by k8 limit 2;"

explain {
sql("""verbose select split_part(replace_empty('we', "", "u"), ":", 5 - 5);""")
notContains "null_type"
}
}