Skip to content

[bug](datetime)when datetime is invalid should check and throw exception#44672

Closed
zhangstar333 wants to merge 3 commits intoapache:masterfrom
zhangstar333:datetime_invalid
Closed

[bug](datetime)when datetime is invalid should check and throw exception#44672
zhangstar333 wants to merge 3 commits intoapache:masterfrom
zhangstar333:datetime_invalid

Conversation

@zhangstar333
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

before: the date_sub fold in FE will have an result is 0000-02-29 16:00:00, which is invalid and it's should check throw exception.

mysql [test]>SELECT  DATE_SUB(CAST('0000-02-28 00:00:00' AS DATETIMEV1), interval -40 hour), bit_Test(1,1);
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INVALID_ARGUMENT]Create Expr failed because [E33] Invalid value: 0000-02-29 16:00:00 for type DateTime

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants