Skip to content

[bug](datetime)when datetime is invalid should check and throw exception #44672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhangstar333 wants to merge 3 commits into from
Closed

[bug](datetime)when datetime is invalid should check and throw exception #44672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc7c570
[bug](datetime)when datetime is invalid should check and throw exception
zhangstar333 Nov 27, 2024
576afe6
update
zhangstar333 Nov 27, 2024
6fdde12
update
zhangstar333 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions ...ore/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateTimeLiteral.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,10 +394,19 @@ public LocalDateTime toJavaDateType() {
((int) getHour()), ((int) getMinute()), ((int) getSecond()), (int) getMicroSecond() * 1000);
}

/**
* use LocalDateTime create Expression
*/
public static Expression fromJavaDateType(LocalDateTime dateTime) {
return isDateOutOfRange(dateTime)
? new NullLiteral(DateTimeType.INSTANCE)
: new DateTimeLiteral(dateTime.getYear(), dateTime.getMonthValue(), dateTime.getDayOfMonth(),
dateTime.getHour(), dateTime.getMinute(), dateTime.getSecond());
if (isDateOutOfRange(dateTime)) {
return new NullLiteral(DateTimeType.INSTANCE);
} else {
if (checkRange(dateTime.getYear(), dateTime.getMonthValue(), dateTime.getDayOfMonth())
|| checkDate(dateTime.getYear(), dateTime.getMonthValue(), dateTime.getDayOfMonth())) {
throw new AnalysisException("datetime [" + dateTime + "] is invalid of range");
}
return new DateTimeLiteral(dateTime.getYear(), dateTime.getMonthValue(), dateTime.getDayOfMonth(),
dateTime.getHour(), dateTime.getMinute(), dateTime.getSecond());
}
}
}
6 changes: 6 additions & 0 deletions regression-test/data/nereids_syntax_p0/test_date_sub.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,9 @@
-- !sql --
12

-- !select --
0000-03-01T16:00 1

-- !select --
0000-03-01T16:00 1

10 changes: 10 additions & 0 deletions regression-test/suites/nereids_syntax_p0/test_date_sub.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,14 @@ suite("test_date_sub") {
qt_sql """ SELECT TIMESTAMPDIFF(DAY,'2003-02-01','2003-05-01') """
qt_sql """ SELECT TIMESTAMPDIFF(WEEK,'2003-02-01','2003-05-01') """

qt_select "SELECT DATE_SUB(CAST('0000-02-28 00:00:00' AS DATETIMEV1),interval -40 hour),bit_Test(1,0);"
explain {
sql("SELECT DATE_SUB(CAST('0000-02-28 00:00:00' AS DATETIMEV1),interval -40 hour),bit_Test(1,0);")
contains "hours_sub"
}
qt_select "SELECT DATE_SUB(CAST('0000-02-28 00:00:00' AS DATETIMEV2),interval -40 hour),bit_Test(1,0);"
explain {
sql("SELECT DATE_SUB(CAST('0000-02-28 00:00:00' AS DATETIMEV2),interval -40 hour),bit_Test(1,0);")
contains "hours_sub"
}
}