Skip to content

branch-3.0: [fix](index)Add duplicated indexes check in add index #46155#46209

Merged
yiguolei merged 1 commit into
branch-3.0from
auto-pick-46155-branch-3.0
Dec 31, 2024
Merged

branch-3.0: [fix](index)Add duplicated indexes check in add index #46155#46209
yiguolei merged 1 commit into
branch-3.0from
auto-pick-46155-branch-3.0

Conversation

@github-actions

@github-actions github-actions Bot commented Dec 31, 2024

Copy link
Copy Markdown
Contributor

Cherry-picked from #46155

[fix](index)Add duplicated indexes check in add index (#46155)
14946f5 
Issue Number: close #46153

Problem Summary:

```
create table t(a int, b int, c tinyint);
alter table t add index idx1(a), add index idx2(a);
alter table t add index idx1(a), add index idx1(a);
```
Both create index sql should fail.
@hello-stephen

hello-stephen commented Dec 31, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 31, 2024
@hello-stephen

hello-stephen commented Dec 31, 2024

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

doris-robot commented Dec 31, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 40873 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 14946f59c8a7f5c20195aacf6ccf95ceaa11c8ca, data reload: false

------ Round 1 ----------------------------------
q1	17572	7472	7260	7260
q2	2063	176	168	168
q3	10540	1112	1199	1112
q4	10578	728	865	728
q5	7778	2896	2849	2849
q6	241	144	141	141
q7	995	620	598	598
q8	9363	1982	2013	1982
q9	6611	6462	6467	6462
q10	6973	2311	2336	2311
q11	455	263	264	263
q12	423	209	213	209
q13	17809	2971	3003	2971
q14	242	210	216	210
q15	580	533	520	520
q16	680	603	607	603
q17	970	534	561	534
q18	7350	6669	6554	6554
q19	1382	1027	1040	1027
q20	475	209	202	202
q21	4058	3158	3291	3158
q22	1099	1011	1012	1011
Total cold run time: 108237 ms
Total hot run time: 40873 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7247	7228	7261	7228
q2	329	230	224	224
q3	2870	2983	2909	2909
q4	2057	1810	1861	1810
q5	5724	5699	5785	5699
q6	229	142	137	137
q7	2268	1798	1846	1798
q8	3382	3539	3542	3539
q9	8824	8919	8911	8911
q10	3592	3563	3591	3563
q11	611	496	503	496
q12	785	600	605	600
q13	11067	3151	3169	3151
q14	304	279	289	279
q15	589	538	519	519
q16	728	679	670	670
q17	1901	1643	1606	1606
q18	8294	7731	7774	7731
q19	1681	1568	1689	1568
q20	2140	1871	1911	1871
q21	5612	5474	5583	5474
q22	1146	1099	1025	1025
Total cold run time: 71380 ms
Total hot run time: 60808 ms

@doris-robot

doris-robot commented Dec 31, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 197872 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 14946f59c8a7f5c20195aacf6ccf95ceaa11c8ca, data reload: false

query1	1295	961	903	903
query2	6236	2126	2105	2105
query3	10926	4415	4360	4360
query4	67538	27818	23542	23542
query5	4901	440	448	440
query6	411	159	164	159
query7	5586	316	313	313
query8	313	230	227	227
query9	9119	2720	2712	2712
query10	463	265	253	253
query11	17199	15168	15792	15168
query12	151	96	102	96
query13	1500	434	416	416
query14	10165	7249	7163	7163
query15	202	173	170	170
query16	7138	473	485	473
query17	1276	583	591	583
query18	1837	317	318	317
query19	211	154	153	153
query20	121	113	114	113
query21	65	45	44	44
query22	4914	4692	4605	4605
query23	34642	34026	34374	34026
query24	6141	2900	2887	2887
query25	549	446	428	428
query26	665	172	168	168
query27	1692	313	322	313
query28	4407	2499	2466	2466
query29	706	458	441	441
query30	248	196	168	168
query31	1006	836	830	830
query32	65	61	63	61
query33	416	298	287	287
query34	940	499	521	499
query35	855	745	746	745
query36	1085	992	968	968
query37	121	77	84	77
query38	4128	4139	3984	3984
query39	1667	1474	1505	1474
query40	144	84	86	84
query41	49	48	47	47
query42	114	97	93	93
query43	548	516	515	515
query44	1186	821	861	821
query45	183	168	168	168
query46	1158	739	731	731
query47	2071	1926	1955	1926
query48	460	394	383	383
query49	711	392	376	376
query50	856	418	422	418
query51	7257	7432	7162	7162
query52	95	83	84	83
query53	248	178	173	173
query54	565	457	440	440
query55	80	77	73	73
query56	244	228	235	228
query57	1273	1095	1093	1093
query58	206	204	191	191
query59	3218	3153	3128	3128
query60	276	245	267	245
query61	108	104	108	104
query62	795	656	650	650
query63	211	188	190	188
query64	1406	652	614	614
query65	3259	3168	3179	3168
query66	695	301	306	301
query67	16115	15732	15718	15718
query68	3874	605	568	568
query69	443	277	288	277
query70	1178	1106	1108	1106
query71	354	244	258	244
query72	6544	4028	3983	3983
query73	771	336	342	336
query74	10203	9019	9077	9019
query75	3337	2664	2667	2664
query76	1944	1148	1068	1068
query77	511	265	266	265
query78	10627	9932	9594	9594
query79	2255	609	602	602
query80	882	427	410	410
query81	533	244	238	238
query82	318	113	115	113
query83	180	148	144	144
query84	289	93	78	78
query85	1022	302	300	300
query86	418	306	308	306
query87	4619	4279	4317	4279
query88	4533	2367	2346	2346
query89	421	294	285	285
query90	2096	179	179	179
query91	195	145	169	145
query92	64	48	51	48
query93	2256	555	552	552
query94	882	311	297	297
query95	349	257	255	255
query96	621	278	278	278
query97	3328	3195	3149	3149
query98	214	201	207	201
query99	1579	1286	1285	1285
Total cold run time: 321271 ms
Total hot run time: 197872 ms

@doris-robot

doris-robot commented Dec 31, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 33.14 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 14946f59c8a7f5c20195aacf6ccf95ceaa11c8ca, data reload: false

query1	0.04	0.03	0.02
query2	0.08	0.02	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.52	0.53	0.53
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.03	0.03
query9	0.56	0.51	0.49
query10	0.55	0.53	0.55
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.59	0.59
query14	2.96	2.89	2.93
query15	0.89	0.81	0.82
query16	0.39	0.38	0.38
query17	1.00	1.00	1.08
query18	0.23	0.22	0.22
query19	1.97	1.85	2.00
query20	0.02	0.01	0.01
query21	15.37	0.58	0.57
query22	2.66	2.05	1.99
query23	16.96	0.90	0.75
query24	2.95	1.17	1.06
query25	0.36	0.09	0.12
query26	0.42	0.14	0.14
query27	0.04	0.03	0.05
query28	10.68	1.11	1.07
query29	12.55	3.28	3.25
query30	0.24	0.06	0.06
query31	2.87	0.38	0.37
query32	3.26	0.46	0.47
query33	2.97	3.06	3.07
query34	17.23	4.47	4.48
query35	4.60	4.52	4.51
query36	0.71	0.49	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.53 s
Total hot run time: 33.14 s

@yiguolei yiguolei merged commit 44357b3 into branch-3.0 Dec 31, 2024
@github-actions github-actions Bot deleted the auto-pick-46155-branch-3.0 branch December 31, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @doris-robot @yiguolei @dataroaring