Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jan 15, 2026

What problem does this PR solve?

Related: #54304

Problem Summary:

Before this change, when a JDBC driver was not found in the new default
directory, the code would fallback to the old directory unconditionally,
even if the driver didn't exist there. In cloud mode, it would try to
download from cloud but then fallback to old directory regardless of
download result.

This commit improves the driver lookup logic:

  1. Check new default directory first (DORIS_HOME/plugins/jdbc_drivers)
  2. Check old default directory (DORIS_HOME/jdbc_drivers)
  3. In cloud mode, only download from cloud if not found in either directory
  4. Return error immediately if driver not found (instead of fallback)

This avoids unnecessary cloud downloads when driver exists in old path,
and provides clearer error messages when driver is truly missing.

Changes:

  • BE: vjdbc_connector.cpp - check old path before cloud download
  • FE: JdbcResource.java - check old path and improve error messages

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 15, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

JNSimba
JNSimba previously approved these changes Jan 15, 2026
Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba
Copy link
Member

JNSimba commented Jan 15, 2026

rum buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 15, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 15, 2026
@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

@JNSimba
Copy link
Member

JNSimba commented Jan 16, 2026

run buildall

JNSimba
JNSimba previously approved these changes Jan 16, 2026
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 16, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 31467 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3f6799a75fd8d9fd9e78a23e55e5a7fb3bfcf805, data reload: false

------ Round 1 ----------------------------------
q1	17609	4412	4048	4048
q2	2050	348	257	257
q3	10142	1277	700	700
q4	10216	879	313	313
q5	7527	2113	1847	1847
q6	191	174	143	143
q7	930	781	642	642
q8	9271	1381	1140	1140
q9	4978	4681	4525	4525
q10	6758	1805	1391	1391
q11	498	296	287	287
q12	703	737	616	616
q13	17813	3837	3118	3118
q14	297	299	265	265
q15	588	503	501	501
q16	680	672	632	632
q17	647	810	496	496
q18	6458	6562	6379	6379
q19	1113	959	641	641
q20	385	352	237	237
q21	3029	2442	2312	2312
q22	1091	997	977	977
Total cold run time: 102974 ms
Total hot run time: 31467 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4114	4062	4027	4027
q2	319	403	328	328
q3	2063	2605	2210	2210
q4	1316	1758	1329	1329
q5	4068	3997	4181	3997
q6	195	165	133	133
q7	1857	1822	1662	1662
q8	2826	2531	2466	2466
q9	7321	7199	6983	6983
q10	2567	2808	2306	2306
q11	533	464	466	464
q12	722	755	602	602
q13	3563	4139	3481	3481
q14	329	329	284	284
q15	546	492	524	492
q16	627	666	647	647
q17	1157	1415	1636	1415
q18	8270	8264	7832	7832
q19	905	909	861	861
q20	1961	2081	1898	1898
q21	5019	4345	4248	4248
q22	1163	1069	1028	1028
Total cold run time: 51441 ms
Total hot run time: 48693 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174337 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3f6799a75fd8d9fd9e78a23e55e5a7fb3bfcf805, data reload: false

query5	4430	618	488	488
query6	358	224	207	207
query7	4218	458	254	254
query8	332	248	261	248
query9	8732	2853	2834	2834
query10	509	356	314	314
query11	15162	15043	14898	14898
query12	173	113	113	113
query13	1261	480	370	370
query14	6196	2979	2841	2841
query14_1	2667	2620	2630	2620
query15	198	190	167	167
query16	976	476	473	473
query17	1082	637	547	547
query18	2462	427	328	328
query19	216	221	195	195
query20	123	114	118	114
query21	216	136	117	117
query22	4057	4153	4034	4034
query23	16083	15730	15304	15304
query23_1	15601	15560	15570	15560
query24	7158	1538	1167	1167
query24_1	1172	1175	1197	1175
query25	585	464	411	411
query26	1251	268	155	155
query27	2766	442	280	280
query28	4587	2132	2134	2132
query29	792	544	448	448
query30	327	244	213	213
query31	807	632	574	574
query32	82	78	78	78
query33	558	366	325	325
query34	898	867	538	538
query35	729	782	705	705
query36	876	906	852	852
query37	132	100	84	84
query38	2750	2701	2680	2680
query39	760	751	755	751
query39_1	706	712	710	710
query40	221	141	124	124
query41	74	68	67	67
query42	105	104	104	104
query43	437	406	415	406
query44	1344	745	763	745
query45	187	190	182	182
query46	830	939	589	589
query47	1465	1457	1329	1329
query48	322	347	246	246
query49	622	431	357	357
query50	623	268	202	202
query51	3767	3783	3732	3732
query52	108	110	97	97
query53	291	327	271	271
query54	310	277	283	277
query55	87	83	78	78
query56	319	325	320	320
query57	1035	1002	961	961
query58	285	273	258	258
query59	2053	2126	2170	2126
query60	358	342	318	318
query61	187	176	200	176
query62	395	356	300	300
query63	300	270	260	260
query64	4904	1251	974	974
query65	3900	3739	3767	3739
query66	1449	417	321	321
query67	15676	15634	15355	15355
query68	2438	1078	725	725
query69	453	369	328	328
query70	1010	960	891	891
query71	318	314	299	299
query72	5344	3216	3270	3216
query73	591	722	312	312
query74	8745	8714	8553	8553
query75	2725	2855	2458	2458
query76	2288	1042	695	695
query77	348	417	321	321
query78	9799	9915	9158	9158
query79	1097	907	593	593
query80	1305	573	479	479
query81	543	265	233	233
query82	1009	145	111	111
query83	325	253	240	240
query84	250	119	95	95
query85	910	511	432	432
query86	422	286	285	285
query87	2863	2856	2766	2766
query88	3515	2586	2568	2568
query89	405	350	333	333
query90	1997	175	165	165
query91	173	157	135	135
query92	83	74	69	69
query93	1064	890	536	536
query94	663	334	313	313
query95	595	391	317	317
query96	647	518	226	226
query97	2346	2396	2325	2325
query98	207	212	197	197
query99	616	589	514	514
Total cold run time: 247593 ms
Total hot run time: 174337 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.83 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3f6799a75fd8d9fd9e78a23e55e5a7fb3bfcf805, data reload: false

query1	0.05	0.05	0.04
query2	0.10	0.04	0.04
query3	0.26	0.08	0.08
query4	1.61	0.12	0.11
query5	0.26	0.25	0.26
query6	1.16	0.65	0.66
query7	0.04	0.02	0.02
query8	0.06	0.04	0.04
query9	0.56	0.50	0.49
query10	0.54	0.56	0.54
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.59	0.60
query14	0.96	0.92	0.95
query15	0.79	0.78	0.78
query16	0.40	0.39	0.40
query17	1.00	1.04	1.09
query18	0.23	0.22	0.22
query19	1.94	1.82	1.85
query20	0.02	0.01	0.01
query21	15.44	0.29	0.14
query22	5.01	0.06	0.05
query23	15.90	0.29	0.10
query24	0.94	0.31	0.66
query25	0.10	0.09	0.08
query26	0.13	0.12	0.13
query27	0.09	0.08	0.05
query28	4.26	1.08	0.89
query29	12.54	3.93	3.17
query30	0.27	0.14	0.13
query31	2.83	0.64	0.39
query32	3.24	0.55	0.46
query33	3.03	2.99	3.05
query34	16.42	5.10	4.46
query35	4.43	4.54	4.42
query36	0.66	0.52	0.49
query37	0.10	0.06	0.07
query38	0.08	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 96.71 s
Total hot run time: 26.83 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

@morningman
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 16, 2026
@doris-robot
Copy link

TPC-H: Total hot run time: 32291 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7585d1ef96232e47e1b39af8c6a4d31b9d081454, data reload: false

------ Round 1 ----------------------------------
q1	17604	4272	4082	4082
q2	2124	386	249	249
q3	10069	1306	739	739
q4	10203	759	305	305
q5	7577	2157	1844	1844
q6	193	168	140	140
q7	953	785	656	656
q8	9270	1398	1175	1175
q9	4928	4704	4574	4574
q10	6729	1814	1427	1427
q11	510	320	277	277
q12	688	752	595	595
q13	17781	3899	3072	3072
q14	295	304	270	270
q15	565	506	507	506
q16	683	684	666	666
q17	628	800	520	520
q18	7214	6761	6968	6761
q19	1295	999	655	655
q20	428	391	267	267
q21	3240	2718	2456	2456
q22	1112	1137	1055	1055
Total cold run time: 104089 ms
Total hot run time: 32291 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4498	4338	4315	4315
q2	362	427	319	319
q3	2254	2748	2436	2436
q4	1408	1844	1422	1422
q5	4362	4366	4450	4366
q6	216	182	130	130
q7	1947	1953	1881	1881
q8	2599	2498	2520	2498
q9	7132	7150	7080	7080
q10	2493	2776	2259	2259
q11	559	489	462	462
q12	710	809	615	615
q13	3669	3893	3125	3125
q14	262	283	279	279
q15	527	485	473	473
q16	629	652	599	599
q17	1137	1285	1307	1285
q18	7671	7236	7188	7188
q19	847	804	817	804
q20	1874	1948	1809	1809
q21	4488	4312	4074	4074
q22	1051	1001	956	956
Total cold run time: 50695 ms
Total hot run time: 48375 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174368 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7585d1ef96232e47e1b39af8c6a4d31b9d081454, data reload: false

query5	4385	653	503	503
query6	344	239	215	215
query7	4230	468	268	268
query8	358	248	233	233
query9	8718	2874	2900	2874
query10	483	383	351	351
query11	15326	15256	14930	14930
query12	176	119	114	114
query13	1246	495	402	402
query14	6052	3084	2824	2824
query14_1	2703	2659	2717	2659
query15	196	191	171	171
query16	1011	488	472	472
query17	1092	663	567	567
query18	2487	436	337	337
query19	225	228	195	195
query20	127	116	116	116
query21	214	141	120	120
query22	3871	3917	3841	3841
query23	16131	15738	15265	15265
query23_1	15405	15412	15408	15408
query24	7125	1578	1179	1179
query24_1	1205	1188	1177	1177
query25	546	452	420	420
query26	1244	268	154	154
query27	2833	450	285	285
query28	4525	2191	2224	2191
query29	802	540	440	440
query30	314	242	208	208
query31	798	640	565	565
query32	85	81	74	74
query33	540	372	329	329
query34	917	873	532	532
query35	743	777	677	677
query36	938	946	852	852
query37	135	101	87	87
query38	2702	2816	2660	2660
query39	769	743	755	743
query39_1	720	706	704	704
query40	216	135	117	117
query41	66	62	66	62
query42	104	101	104	101
query43	451	424	411	411
query44	1338	751	781	751
query45	185	193	176	176
query46	857	949	585	585
query47	1454	1424	1390	1390
query48	313	328	239	239
query49	619	429	342	342
query50	627	271	207	207
query51	3793	3796	3810	3796
query52	107	106	97	97
query53	301	326	269	269
query54	299	283	261	261
query55	84	82	83	82
query56	308	305	308	305
query57	1069	1018	913	913
query58	270	267	271	267
query59	2208	2182	2040	2040
query60	347	351	315	315
query61	146	148	144	144
query62	397	354	311	311
query63	299	268	263	263
query64	4974	1301	962	962
query65	3809	3713	3760	3713
query66	1448	418	310	310
query67	15696	15636	15583	15583
query68	2460	1107	790	790
query69	460	359	322	322
query70	1047	963	982	963
query71	335	311	308	308
query72	5271	3075	3246	3075
query73	611	754	321	321
query74	8760	8760	8579	8579
query75	2756	2806	2451	2451
query76	2275	1059	680	680
query77	354	385	322	322
query78	9894	10078	9258	9258
query79	1258	919	580	580
query80	1452	581	515	515
query81	552	262	242	242
query82	1306	144	113	113
query83	362	257	241	241
query84	256	116	101	101
query85	1115	485	448	448
query86	430	296	296	296
query87	2890	2856	2765	2765
query88	3560	2623	2565	2565
query89	388	345	321	321
query90	1909	176	152	152
query91	167	160	134	134
query92	81	75	66	66
query93	1144	951	556	556
query94	680	323	294	294
query95	584	413	328	328
query96	651	516	226	226
query97	2354	2398	2324	2324
query98	212	204	202	202
query99	626	578	518	518
Total cold run time: 248605 ms
Total hot run time: 174368 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.65 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7585d1ef96232e47e1b39af8c6a4d31b9d081454, data reload: false

query1	0.05	0.05	0.04
query2	0.09	0.05	0.05
query3	0.25	0.08	0.09
query4	1.63	0.12	0.11
query5	0.26	0.25	0.25
query6	1.14	0.65	0.65
query7	0.03	0.02	0.03
query8	0.05	0.04	0.04
query9	0.58	0.51	0.49
query10	0.55	0.55	0.56
query11	0.15	0.09	0.09
query12	0.14	0.11	0.11
query13	0.60	0.58	0.59
query14	0.95	0.94	0.95
query15	0.81	0.78	0.79
query16	0.40	0.39	0.39
query17	1.07	1.06	1.06
query18	0.22	0.21	0.22
query19	1.92	1.80	1.81
query20	0.02	0.01	0.01
query21	15.44	0.27	0.14
query22	5.25	0.05	0.05
query23	15.91	0.28	0.10
query24	1.02	0.75	0.17
query25	0.09	0.06	0.07
query26	0.14	0.13	0.13
query27	0.09	0.06	0.06
query28	4.09	1.09	0.89
query29	12.57	3.92	3.14
query30	0.31	0.14	0.12
query31	2.81	0.65	0.39
query32	3.30	0.56	0.47
query33	2.98	3.00	3.06
query34	16.14	5.30	4.43
query35	4.53	4.41	4.49
query36	0.67	0.51	0.49
query37	0.12	0.06	0.07
query38	0.08	0.04	0.03
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.10	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.03
Total cold run time: 96.85 s
Total hot run time: 26.65 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.39% (19029/36319)
Line Coverage 35.72% (176337/493724)
Region Coverage 32.25% (136536/423345)
Branch Coverage 33.15% (59027/178061)

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32384 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7585d1ef96232e47e1b39af8c6a4d31b9d081454, data reload: false

------ Round 1 ----------------------------------
q1	17595	4240	4160	4160
q2	2032	357	251	251
q3	10141	1295	723	723
q4	10216	839	307	307
q5	7523	2071	1853	1853
q6	197	177	146	146
q7	931	814	659	659
q8	9276	1404	1174	1174
q9	4986	4672	4585	4585
q10	6808	1816	1446	1446
q11	558	309	307	307
q12	735	757	605	605
q13	17904	3998	3244	3244
q14	306	306	288	288
q15	602	531	527	527
q16	715	712	659	659
q17	748	833	565	565
q18	6838	6545	6603	6545
q19	1161	1012	690	690
q20	429	382	257	257
q21	3128	2474	2405	2405
q22	1068	1004	988	988
Total cold run time: 103897 ms
Total hot run time: 32384 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4175	4106	4107	4106
q2	334	416	322	322
q3	2140	2605	2238	2238
q4	1361	1806	1358	1358
q5	4179	4031	4088	4031
q6	220	173	133	133
q7	1903	2135	1867	1867
q8	2676	2570	2506	2506
q9	7354	7193	7443	7193
q10	2542	2875	2249	2249
q11	569	524	454	454
q12	732	760	606	606
q13	3647	4244	3544	3544
q14	291	313	315	313
q15	552	530	498	498
q16	682	711	659	659
q17	1309	1428	1519	1428
q18	8371	8042	7888	7888
q19	944	874	894	874
q20	2022	2129	1959	1959
q21	4822	4255	4247	4247
q22	1082	1050	1023	1023
Total cold run time: 51907 ms
Total hot run time: 49496 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 177484 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7585d1ef96232e47e1b39af8c6a4d31b9d081454, data reload: false

query5	4443	673	529	529
query6	352	246	225	225
query7	4223	483	273	273
query8	354	267	252	252
query9	8710	3135	3109	3109
query10	541	388	332	332
query11	15591	15297	14919	14919
query12	183	122	123	122
query13	1250	532	421	421
query14	6064	3065	2831	2831
query14_1	2713	2717	2684	2684
query15	204	194	178	178
query16	985	492	501	492
query17	1104	667	596	596
query18	2465	463	346	346
query19	233	227	205	205
query20	128	116	123	116
query21	224	146	117	117
query22	3914	4042	3922	3922
query23	16211	15703	15534	15534
query23_1	15387	15535	15548	15535
query24	7260	1580	1222	1222
query24_1	1216	1211	1208	1208
query25	550	461	409	409
query26	1261	277	165	165
query27	2751	472	297	297
query28	4475	2366	2363	2363
query29	765	544	463	463
query30	314	250	211	211
query31	815	639	596	596
query32	91	81	82	81
query33	538	394	318	318
query34	916	904	549	549
query35	731	768	689	689
query36	947	945	876	876
query37	143	103	92	92
query38	2800	2695	2681	2681
query39	789	762	769	762
query39_1	717	719	726	719
query40	232	144	124	124
query41	68	69	65	65
query42	109	110	107	107
query43	509	503	445	445
query44	1453	816	815	815
query45	188	187	183	183
query46	891	985	612	612
query47	1421	1480	1339	1339
query48	333	344	258	258
query49	604	433	354	354
query50	669	280	232	232
query51	3870	3954	3789	3789
query52	107	110	103	103
query53	312	335	273	273
query54	344	279	263	263
query55	84	83	80	80
query56	320	318	313	313
query57	1023	1026	936	936
query58	278	273	273	273
query59	2291	2214	2122	2122
query60	346	342	313	313
query61	152	149	147	147
query62	404	368	323	323
query63	305	283	275	275
query64	4872	1283	970	970
query65	3865	3775	3794	3775
query66	1475	418	333	333
query67	15799	15832	15601	15601
query68	2439	1189	834	834
query69	463	379	342	342
query70	1069	995	936	936
query71	342	318	306	306
query72	5313	3159	3231	3159
query73	663	754	338	338
query74	8789	8843	8610	8610
query75	2790	2828	2569	2569
query76	2276	1083	719	719
query77	384	387	314	314
query78	9901	9937	9165	9165
query79	2414	953	643	643
query80	1722	590	498	498
query81	547	266	251	251
query82	990	156	114	114
query83	335	264	255	255
query84	255	124	102	102
query85	891	507	438	438
query86	423	320	306	306
query87	2916	2921	2859	2859
query88	3848	2865	2805	2805
query89	401	350	332	332
query90	1994	183	174	174
query91	171	165	147	147
query92	84	77	76	76
query93	1182	967	585	585
query94	641	335	292	292
query95	603	409	349	349
query96	737	535	250	250
query97	2367	2386	2316	2316
query98	251	209	198	198
query99	651	604	553	553
Total cold run time: 252432 ms
Total hot run time: 177484 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.22 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7585d1ef96232e47e1b39af8c6a4d31b9d081454, data reload: false

query1	0.05	0.05	0.05
query2	0.11	0.05	0.05
query3	0.26	0.10	0.08
query4	1.61	0.12	0.12
query5	0.29	0.25	0.25
query6	1.17	0.68	0.66
query7	0.03	0.02	0.02
query8	0.06	0.04	0.05
query9	0.57	0.52	0.52
query10	0.56	0.55	0.56
query11	0.15	0.10	0.10
query12	0.15	0.11	0.11
query13	0.61	0.60	0.59
query14	0.97	0.95	0.96
query15	0.81	0.79	0.81
query16	0.38	0.40	0.39
query17	1.02	1.02	1.02
query18	0.24	0.22	0.22
query19	1.97	1.83	1.90
query20	0.02	0.01	0.01
query21	15.44	0.28	0.14
query22	4.83	0.06	0.05
query23	15.71	0.30	0.10
query24	2.03	0.35	1.24
query25	0.12	0.07	0.06
query26	0.15	0.14	0.14
query27	0.09	0.05	0.06
query28	4.90	1.06	0.89
query29	12.54	4.08	3.24
query30	0.28	0.14	0.13
query31	2.81	0.64	0.39
query32	3.26	0.57	0.45
query33	2.99	3.06	3.18
query34	16.23	5.25	4.47
query35	4.50	4.50	4.49
query36	0.66	0.52	0.50
query37	0.11	0.07	0.06
query38	0.08	0.05	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 98.15 s
Total hot run time: 27.22 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 42.86% (3/7) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.39% (19029/36319)
Line Coverage 35.71% (176324/493724)
Region Coverage 32.22% (136418/423345)
Branch Coverage 33.14% (59002/178061)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 19, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor Author

run check_coverage

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 69.76% (24833/35597)
Line Coverage 52.05% (256669/493142)
Region Coverage 49.44% (211529/427847)
Branch Coverage 50.77% (90780/178822)

@morningman morningman merged commit 85f39d5 into apache:master Jan 19, 2026
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 19, 2026
### What problem does this PR solve?

Related: #54304

Problem Summary:

Before this change, when a JDBC driver was not found in the new default
directory, the code would fallback to the old directory unconditionally,
even if the driver didn't exist there. In cloud mode, it would try to
download from cloud but then fallback to old directory regardless of
download result.

This commit improves the driver lookup logic:
1. Check new default directory first (DORIS_HOME/plugins/jdbc_drivers)
2. Check old default directory (DORIS_HOME/jdbc_drivers)
3. In cloud mode, only download from cloud if not found in either
directory
4. Return error immediately if driver not found (instead of fallback)

This avoids unnecessary cloud downloads when driver exists in old path,
and provides clearer error messages when driver is truly missing.

Changes:
- BE: vjdbc_connector.cpp - check old path before cloud download
- FE: JdbcResource.java - check old path and improve error messages
yiguolei pushed a commit that referenced this pull request Jan 20, 2026
… cloud #59928 (#60038)

Cherry-picked from #59928

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/4.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants