branch-4.0: [fix](jdbc) check old driver path before downloading from cloud #59928 #60038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What problem does this PR solve? Related: #54304 Problem Summary: Before this change, when a JDBC driver was not found in the new default directory, the code would fallback to the old directory unconditionally, even if the driver didn't exist there. In cloud mode, it would try to download from cloud but then fallback to old directory regardless of download result. This commit improves the driver lookup logic: 1. Check new default directory first (DORIS_HOME/plugins/jdbc_drivers) 2. Check old default directory (DORIS_HOME/jdbc_drivers) 3. In cloud mode, only download from cloud if not found in either directory 4. Return error immediately if driver not found (instead of fallback) This avoids unnecessary cloud downloads when driver exists in old path, and provides clearer error messages when driver is truly missing. Changes: - BE: vjdbc_connector.cpp - check old path before cloud download - FE: JdbcResource.java - check old path and improve error messages
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
LGTM |
Contributor
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
skip buildall |
yiguolei
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #59928