[cleanup](iwyu) Remove unnecessary includes of glog/logging.h and boost/iterator_facade.hpp#61523
Open
shuke987 wants to merge 3 commits intoapache:masterfrom
Open
[cleanup](iwyu) Remove unnecessary includes of glog/logging.h and boost/iterator_facade.hpp#61523shuke987 wants to merge 3 commits intoapache:masterfrom
shuke987 wants to merge 3 commits intoapache:masterfrom
Conversation
…files IWYU analysis identified these files do not directly use glog logging macros (LOG, DCHECK, CHECK, etc.). The header is transitively available through other included headers. Verified: full BE build passes with zero compilation errors.
…facade.hpp> from 55 files IWYU analysis identified these files do not directly use boost iterator_facade. The header is transitively available through other included headers. Verified: full BE incremental build passes with zero compilation errors.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include <glog/logging.h>from 81 BE source files#include <boost/iterator/iterator_facade.hpp>from 55 BE source filesThese headers are transitively included through other headers and are not directly used in the affected files. Identified by include-what-you-use (IWYU 0.24 / Clang 20) analysis of the full BE codebase.
Test plan
🤖 Generated with Claude Code