Skip to content

[cleanup](iwyu) Remove unnecessary includes of glog/logging.h and boost/iterator_facade.hpp#61523

Open
shuke987 wants to merge 3 commits intoapache:masterfrom
shuke987:iwyu-cleanup-glog
Open

[cleanup](iwyu) Remove unnecessary includes of glog/logging.h and boost/iterator_facade.hpp#61523
shuke987 wants to merge 3 commits intoapache:masterfrom
shuke987:iwyu-cleanup-glog

Conversation

@shuke987
Copy link
Collaborator

Summary

  • Remove unnecessary #include <glog/logging.h> from 81 BE source files
  • Remove unnecessary #include <boost/iterator/iterator_facade.hpp> from 55 BE source files
  • Total: 136 files cleaned, 137 lines removed

These headers are transitively included through other headers and are not directly used in the affected files. Identified by include-what-you-use (IWYU 0.24 / Clang 20) analysis of the full BE codebase.

Test plan

  • Full BE build passes with zero compilation errors after glog removal
  • Incremental BE build passes with zero compilation errors after boost removal
  • CI pipeline

🤖 Generated with Claude Code

…files

IWYU analysis identified these files do not directly use glog logging
macros (LOG, DCHECK, CHECK, etc.). The header is transitively available
through other included headers.

Verified: full BE build passes with zero compilation errors.
…facade.hpp> from 55 files

IWYU analysis identified these files do not directly use boost iterator_facade.
The header is transitively available through other included headers.

Verified: full BE incremental build passes with zero compilation errors.
@Thearas
Copy link
Contributor

Thearas commented Mar 19, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants