branch-4.0: [Enhancement](Recycler) Add bvar metrics for operation logs #60520#61879
Closed
Yukang-Lian wants to merge 1 commit intoapache:branch-4.0from
Closed
branch-4.0: [Enhancement](Recycler) Add bvar metrics for operation logs #60520#61879Yukang-Lian wants to merge 1 commit intoapache:branch-4.0from
Yukang-Lian wants to merge 1 commit intoapache:branch-4.0from
Conversation
…0520) - Add dedicated bvar metrics for the recycle_operation_logs path, which previously had no observability through the monitoring system - Introduce OplogRecycleStats to track per-round recycling statistics including skipped-by-snapshot count, earliest recyclable version, failure count, and generated recycle key counts (partition/index/rowset/txn) - Add scan_and_statistics_operation_logs() to collect pre-recycling statistics via RecyclerMetricsContext, consistent with existing scan_and_statistics_* functions - Use a PendingCounts pattern in OperationLogRecycler to avoid inflating committed metrics on transaction failure — local counts are only merged into OplogRecycleStats atomics after successful commit() - All new statistics are gated behind the enable_recycler_stats_metrics config flag
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
Superseded by #61920 (combined cherry-pick PR for branch-4.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick #60520 to branch-4.0.
recycle_operation_logspathOplogRecycleStatsto track per-round recycling statisticsscan_and_statistics_operation_logs()for pre-recycling statisticsenable_recycler_stats_metricsconfig flag