Skip to content

branch-4.0: [pick] Cherry-pick #60520 #60239 #59331 #60310#61920

Merged
yiguolei merged 5 commits intoapache:branch-4.0from
Yukang-Lian:combined-picks-branch-4.0
Mar 31, 2026
Merged

branch-4.0: [pick] Cherry-pick #60520 #60239 #59331 #60310#61920
yiguolei merged 5 commits intoapache:branch-4.0from
Yukang-Lian:combined-picks-branch-4.0

Conversation

@Yukang-Lian
Copy link
Copy Markdown
Collaborator

Proposed changes

Cherry-pick the following PRs to branch-4.0:

…0520)

- Add dedicated bvar metrics for the recycle_operation_logs path, which
previously had no observability through the monitoring system
- Introduce OplogRecycleStats to track per-round recycling statistics
including skipped-by-snapshot count, earliest recyclable version,
failure count, and generated recycle key counts
(partition/index/rowset/txn)
- Add scan_and_statistics_operation_logs() to collect pre-recycling
statistics via RecyclerMetricsContext, consistent with existing
scan_and_statistics_* functions
- Use a PendingCounts pattern in OperationLogRecycler to avoid inflating
committed metrics on transaction failure — local counts are only merged
into OplogRecycleStats atomics after successful
commit()
- All new statistics are gated behind the enable_recycler_stats_metrics
config flag
…apache#60239)

Cluster snapshot operations are currently restricted to root user only.
Some customers need to allow ADMIN users to manage cluster snapshots
without granting root access.
Solution
Add a new configuration cluster_snapshot_min_privilege to control the
minimum privilege level:
- root (default): Only root user can execute
- admin: Users with ADMIN privilege can execute
Affects 4 cluster snapshot commands and 2 information_schema tables
(cluster_snapshots, cluster_snapshot_properties).
@Yukang-Lian Yukang-Lian requested a review from yiguolei as a code owner March 31, 2026 04:13
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Copy Markdown
Collaborator Author

run buildall

@doris-robot
Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 70.79% (143/202) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.96% (19225/36300)
Line Coverage 36.13% (179109/495760)
Region Coverage 32.74% (138909/424286)
Branch Coverage 33.70% (60290/178888)

@Yukang-Lian Yukang-Lian force-pushed the combined-picks-branch-4.0 branch from 1d30ebb to dbd85e5 Compare March 31, 2026 07:54
@Yukang-Lian
Copy link
Copy Markdown
Collaborator Author

run buildall

@doris-robot
Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 83.75% (201/240) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.35% (1795/2262)
Line Coverage 64.64% (32185/49794)
Region Coverage 65.46% (16097/24590)
Branch Coverage 56.05% (8583/15312)

@hello-stephen
Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 48.98% (24/49) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 70.79% (143/202) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.96% (19225/36300)
Line Coverage 36.13% (179124/495760)
Region Coverage 32.78% (139101/424286)
Branch Coverage 33.71% (60305/178888)

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 91.05% (173/190) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.39% (25366/35534)
Line Coverage 54.07% (267583/494865)
Region Coverage 51.71% (221604/428559)
Branch Coverage 53.12% (95358/179531)

@yiguolei yiguolei merged commit e16a6a5 into apache:branch-4.0 Mar 31, 2026
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants