[fix](memtable) using memtable memory instead of load memory to calculate adaptive write buffer size#62104
Merged
liaoxin01 merged 1 commit intoapache:masterfrom Apr 8, 2026
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 28957 ms |
TPC-DS: Total hot run time: 178826 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_adaptive_write_buffer_size()usedMemoryProfile::load_current_usage()to evaluate memory pressure, but this metric does not include memtable memory. As a result, even when memtable memory is high, the pressure check always reads near zero, causing the write buffer to always use the maximum 4× factor and never scale down — defeating the purpose of adaptive sizing.Solution
Replace
MemoryProfile::load_current_usage()withmemtable_memory_limiter()->mem_tracker()->consumption(), which directly reflects actual memtable memory consumption. The scaling logic remains the same:A null check is added for safety in case the limiter or tracker is not initialized.