Skip to content

[fix](fe) Remove oidc plugin assertions from AuthenticationPluginManagerTest#63323

Open
heguanhui wants to merge 1 commit into
apache:masterfrom
heguanhui:fix/remove-oidc-test-assertion
Open

[fix](fe) Remove oidc plugin assertions from AuthenticationPluginManagerTest#63323
heguanhui wants to merge 1 commit into
apache:masterfrom
heguanhui:fix/remove-oidc-test-assertion

Conversation

@heguanhui
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: AuthenticationPluginManagerTest asserts the existence of an OIDC authentication plugin (oidc), but no OIDC plugin implementation exists in the codebase. The OidcPluginFactory class referenced in AuthenticationPluginFactory.java comments is only a documentation example with no actual implementation, module, or SPI registration. This causes testPluginsAutoLoaded and testGetFactory to fail.

Release note

None

Check List (For Author)

  • Test
    • Unit Test
  • Behavior changed:
    • No.
  • Does this need documentation?
    • No.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…gerTest

### What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: AuthenticationPluginManagerTest asserts the existence of an OIDC authentication plugin, but no OIDC plugin implementation exists in the codebase. This causes testPluginsAutoLoaded and testGetFactory to fail.

### Release note

None

### Check List (For Author)

- Test: Unit Test
- Behavior changed: No
- Does this need documentation: No
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants