[fix](fe) Remove oidc plugin assertions from AuthenticationPluginManagerTest#63323
Open
heguanhui wants to merge 1 commit into
Open
[fix](fe) Remove oidc plugin assertions from AuthenticationPluginManagerTest#63323heguanhui wants to merge 1 commit into
heguanhui wants to merge 1 commit into
Conversation
…gerTest ### What problem does this PR solve? Issue Number: close #xxx Problem Summary: AuthenticationPluginManagerTest asserts the existence of an OIDC authentication plugin, but no OIDC plugin implementation exists in the codebase. This causes testPluginsAutoLoaded and testGetFactory to fail. ### Release note None ### Check List (For Author) - Test: Unit Test - Behavior changed: No - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
AuthenticationPluginManagerTestasserts the existence of an OIDC authentication plugin (oidc), but no OIDC plugin implementation exists in the codebase. TheOidcPluginFactoryclass referenced inAuthenticationPluginFactory.javacomments is only a documentation example with no actual implementation, module, or SPI registration. This causestestPluginsAutoLoadedandtestGetFactoryto fail.Release note
None
Check List (For Author)
Check List (For Reviewer who merge this PR)