Skip to content

[fix](fe) Remove oidc plugin assertions from AuthenticationPluginManagerTest #63323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heguanhui wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix](fe) Remove oidc plugin assertions from AuthenticationPluginManagerTest #63323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...rc/test/java/org/apache/doris/authentication/handler/AuthenticationPluginManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ void testPluginsAutoLoaded() {
// Then
Assertions.assertNotNull(pluginNames);
Assertions.assertFalse(pluginNames.isEmpty(), "Should load at least built-in plugins");
Assertions.assertTrue(pluginNames.contains("oidc"), "Should include oidc plugin");
Assertions.assertTrue(pluginNames.contains("password"), "Should include password plugin");
}

Expand Down Expand Up @@ -147,10 +146,6 @@ void testGetFactory() {
// Then
Assertions.assertTrue(factory.isPresent());
Assertions.assertEquals("password", factory.get().name());

Optional<AuthenticationPluginFactory> oidcFactory = pluginManager.getFactory("oidc");
Assertions.assertTrue(oidcFactory.isPresent());
Assertions.assertEquals("oidc", oidcFactory.get().name());
}

@Test
Expand Down
Loading