[refactor](be) Remove unused JSON helpers#64002
Merged
Merged
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Remove dead helper code from BE JSON-related implementations. ExecuteReducer and its JsonParser/path parsing helper chain in function_json.cpp had no live callers after the registered JSON functions were narrowed to json_quote, json_unquote, and json_valid. The Jsonb-to-RapidJSON conversion helper also became unused, so this removes its declaration/definition and the only commented-out test helper that referenced it. The remaining small changes clean up now-unneeded includes and const/range-loop style around the touched code.
### Release note
None
### Check List (For Author)
- Test: Manual test
- DORIS_HOME=/mnt/disk7/hushenggang/doris ninja -C be/ut_build_ASAN src/core/CMakeFiles/Core.dir/data_type_serde/data_type_jsonb_serde.cpp.o src/exprs/CMakeFiles/Exprs.dir/function/function_json.cpp.o test/CMakeFiles/doris_be_test.dir/core/column/column_variant_test.cpp.o
- build-support/clang-format.sh
- build-support/check-format.sh
- git diff --check
- Behavior changed: No
- Does this need documentation: No
Member
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review opinion: approve / no blocking issues found.
Critical checkpoint conclusions:
- Goal and proof: The PR removes unused BE JSON helper code. I verified the removed symbols only had self-references or a commented-out test reference at the base commit, and live JSON function registrations remain in
function_json.cpp/function_jsonb.cpp. Author-provided testing is object compilation plus format checks; I also rangit diff --checklocally. - Scope: The change is small and focused on dead-code deletion plus minor style cleanup in touched code.
- Concurrency/lifecycle: No new concurrency, shared state, static initialization, or lifecycle behavior is introduced.
- Config/compatibility/protocol: No new configs, serialization formats, thrift/protobuf contracts, or FE-BE protocol changes.
- Parallel code paths: Live JSON path/extract helpers remain in
json_functions.cppand JSONB implementations remain registered infunction_jsonb.cpp; no missing parallel update found. - Error handling/data correctness: No runtime behavior path is changed by the removed unused helpers; remaining touched functions keep existing Status/null handling.
- Tests/results: No new functional tests are needed for dead-code removal. I could not run BE object compilation in this runner because no
be/ut_build_ASANbuild directory exists. - Observability/performance: No observability need; removing dead code reduces compile surface and has no runtime performance risk.
- User focus: No additional user-provided review focus was specified.
Member
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-H: Total hot run time: 28774 ms |
Contributor
TPC-DS: Total hot run time: 170096 ms |
yiguolei
approved these changes
Jun 2, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Problem Summary:
Remove dead helper code from BE JSON-related implementations:
ExecuteReducertemplate and itsJsonParser/path parsing helper chain fromfunction_json.cpp.convert_jsonb_to_rapidjsondeclaration/definition after its only live dependency was removed.This is an internal cleanup only and does not change JSON function behavior.
Release note
None
Check List (For Author)
ninja -C be/ut_build_ASAN src/core/CMakeFiles/Core.dir/data_type_serde/data_type_jsonb_serde.cpp.o src/exprs/CMakeFiles/Exprs.dir/function/function_json.cpp.o test/CMakeFiles/doris_be_test.dir/core/column/column_variant_test.cpp.obuild-support/clang-format.shbuild-support/check-format.shgit diff --check