Skip to content

[refactor](be) Remove unused JSON helpers #64002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrhhsg merged 1 commit into from
Jun 3, 2026
Merged

[refactor](be) Remove unused JSON helpers #64002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 0 additions & 75 deletions be/src/core/data_type_serde/data_type_jsonb_serde.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@

#include "core/data_type_serde/data_type_jsonb_serde.h"

#include <rapidjson/document.h>
#include <rapidjson/stringbuffer.h>
#include <rapidjson/writer.h>

#include <cstddef>
#include <cstdint>
#include <memory>
Expand Down Expand Up @@ -265,77 +261,6 @@ Status DataTypeJsonbSerDe::read_column_from_pb(IColumn& column, const PValues& a
return Status::OK();
}

void convert_jsonb_to_rapidjson(const JsonbValue& val, rapidjson::Value& target,
rapidjson::Document::AllocatorType& allocator) {
// convert type of jsonb to rapidjson::Value
switch (val.type) {
case JsonbType::T_True:
target.SetBool(true);
break;
case JsonbType::T_False:
target.SetBool(false);
break;
case JsonbType::T_Null:
target.SetNull();
break;
case JsonbType::T_Float:
target.SetFloat(val.unpack<JsonbFloatVal>()->val());
break;
case JsonbType::T_Double:
target.SetDouble(val.unpack<JsonbDoubleVal>()->val());
break;
case JsonbType::T_Int64:
target.SetInt64(val.unpack<JsonbInt64Val>()->val());
break;
case JsonbType::T_Int32:
target.SetInt(val.unpack<JsonbInt32Val>()->val());
break;
case JsonbType::T_Int16:
target.SetInt(val.unpack<JsonbInt16Val>()->val());
break;
case JsonbType::T_Int8:
target.SetInt(val.unpack<JsonbInt8Val>()->val());
break;
case JsonbType::T_String:
target.SetString(val.unpack<JsonbStringVal>()->getBlob(),
val.unpack<JsonbStringVal>()->getBlobLen());
break;
case JsonbType::T_Array: {
target.SetArray();
const ArrayVal& array = *val.unpack<ArrayVal>();
if (array.numElem() == 0) {
target.SetNull();
break;
}
target.Reserve(array.numElem(), allocator);
for (auto it = array.begin(); it != array.end(); ++it) {
rapidjson::Value array_val;
convert_jsonb_to_rapidjson(*static_cast<const JsonbValue*>(it), array_val, allocator);
target.PushBack(array_val, allocator);
}
break;
}
case JsonbType::T_Object: {
target.SetObject();
const ObjectVal& obj = *val.unpack<ObjectVal>();
for (auto it = obj.begin(); it != obj.end(); ++it) {
rapidjson::Value obj_val;
convert_jsonb_to_rapidjson(*it->value(), obj_val, allocator);
target.AddMember(rapidjson::GenericStringRef(it->getKeyStr(), it->klen()), obj_val,
allocator);
}
break;
}
case JsonbType::T_Int128: {
target.SetUint64(static_cast<uint64_t>(val.unpack<JsonbInt128Val>()->val()));
break;
}
default:
CHECK(false) << "unkown type " << static_cast<int>(val.type);
break;
}
}

Status DataTypeJsonbSerDe::serialize_column_to_jsonb(const IColumn& from_column, int64_t row_num,
JsonbWriter& writer) const {
const auto& jsonb_binary = assert_cast<const ColumnString&>(from_column).get_data_at(row_num);
Expand Down
3 changes: 0 additions & 3 deletions be/src/core/data_type_serde/data_type_jsonb_serde.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,4 @@ class DataTypeJsonbSerDe : public DataTypeStringSerDe {
void to_string(const IColumn& column, size_t row_num, BufferWritable& bw,
const FormatOptions& options) const override;
};

void convert_jsonb_to_rapidjson(const JsonbValue& val, rapidjson::Value& target,
rapidjson::Document::AllocatorType& allocator);
} // namespace doris
Loading
Loading