[Enhancement] (binlog<row>) move write lsn on sink, ensure lsn same on all replica#64133
Open
Userwhite wants to merge 2 commits into
Open
[Enhancement] (binlog<row>) move write lsn on sink, ensure lsn same on all replica#64133Userwhite wants to merge 2 commits into
Userwhite wants to merge 2 commits into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 29456 ms |
Contributor
TPC-DS: Total hot run time: 170843 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #61956
Related PR: #63110
Problem Summary:
Currently, LSNs are assigned on the BE TabletWriter side during writes, with each node allocating them independently.
As a result, replicas may end up with inconsistent LSNs when reading.
We are now moving LSN allocation to the sink side so that the same batch of data gets a fixed LSN.
At the same time, for publish-conflict cases, we preserve consistency by proactively reading the old LSN instead of allocating a new one.
In addition,fix 2 bug about binlog:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)