[fix](regression) Use local HTTP resources in TVF test#65299
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: The HTTP TVF regression test depended on hard-coded GitHub raw URLs for checked-in test data, making the P0 case sensitive to external network availability. This change serves regression data from a temporary local HTTP server during the suite and points HTTP/file TVF URLs at that server, while preserving HuggingFace-specific URI coverage. In distributed test environments, the local HTTP server host can be set through httpTvfHost to an address that every BE can reach.
### Release note
None
### Check List (For Author)
- Test: Regression test
- ./run-regression-test.sh --run -d external_table_p0/tvf -s test_http_tvf -jdbc "jdbc:mysql://127.0.0.1:59030/?useLocalSessionState=true&allowLoadLocalInfile=true&zeroDateTimeBehavior=round" -ha 127.0.0.1:58030 -conf httpTvfHost=10.26.20.3 (on gabriel@10.26.20.3:/mnt/disk3/gabriel/Workspace/dev2/doris, passed; local HTTP URLs used 10.26.20.3)
- Behavior changed: No
- Does this need documentation: No
e1e3d36 to
a59a310
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated review summary for PR 65299:
I reviewed the single changed regression suite and the related HTTP TVF FE/BE paths. I did not find a substantiated blocking issue, so I am leaving this as a comment-only review with no inline comments.
Critical checkpoint conclusions:
- Goal and test proof: the change replaces raw GitHub data URLs in
test_http_tvfwith a per-suite local HTTP server while preserving HuggingFace URI coverage. The referenced local data files exist, and the local blobs match the original GitHub refs, including the previously pinned4.0.2-rc02CSV. The existing.outfile does not include the substituted URLs. - Scope: the PR is focused on one regression test file and does not alter product code paths.
- Concurrency and lifecycle: the only new lifecycle is the per-suite
HttpServer; the SQL checks are synchronous and the server is stopped infinally. - Config/session propagation:
httpTvfHostis accepted through the existing-conf key=valuepath intootherConfigs; fallback toexternalEnvIpmatches existing regression conventions. - Parallel paths and compatibility:
http(...)andfile(... fs.http.support=true)still flow through the same FE TVF property handling and BE HTTP reader. FE HEAD size discovery and BE range/non-range reads are covered by the local server behavior. - Test outputs: no generated output change was needed; added patch lines have no trailing whitespace.
- Validation limit: I did not run the full regression suite in this checkout because
.worktree_initialized,thirdparty/installed, andthirdparty/installed/bin/protocare missing. The PR body reports a successful targeted regression run by the author.
Subagent conclusions:
optimizer-rewrite: no optimizer/rewrite candidate; convergence round 1 repliedNO_NEW_VALUABLE_FINDINGS.tests-session-config: no tests/session/config candidate; convergence round 1 repliedNO_NEW_VALUABLE_FINDINGS.- No subagent candidate became an inline comment, and no duplicate candidate needed merging.
User focus: no additional user-provided review focus was supplied.
morningman
approved these changes
Jul 7, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This was referenced Jul 7, 2026
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Jul 7, 2026
(cherry picked from commit 553c23d)
yiguolei
pushed a commit
that referenced
this pull request
Jul 8, 2026
…65313) ## Proposed changes Backport #65299 to branch-4.1. This updates the HTTP TVF regression test to serve local `regression-test/data` files through an in-process HTTP server instead of fetching raw GitHub-hosted URLs. ## Notes Resolved the suite-tag conflict by preserving branch-4.1's existing `p2` classification. ## Validation - `git diff --check origin/branch-4.1..codex/backport-65299-branch-4.1` - Verified all local `regression-test/data` files referenced by `httpUrl(...)` exist on the backport branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix Use local HTTP resources in TVF test
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: The HTTP TVF regression test depended on hard-coded GitHub raw URLs for checked-in test data, making the P0 case sensitive to external network availability. This change serves regression data from a temporary local HTTP server during the suite and points HTTP/file TVF URLs at that server, while preserving HuggingFace-specific URI coverage. In distributed test environments, the local HTTP server host can be set through httpTvfHost to an address that every BE can reach.
Release note
None
Check List (For Author)