[test](inverted index) remove regression case for inverted index cache#65341
[test](inverted index) remove regression case for inverted index cache#65341shuke987 wants to merge 1 commit into
Conversation
…e, use ut instead (apache#58137) (cherry picked from commit 86b9973)
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
/review |
There was a problem hiding this comment.
Comment-only review: I did not find a blocking correctness issue in this PR.
Checked the changed files and surrounding cache paths. The removed Groovy fault-injection suite is replaced by the newly exposed InvertedIndexReaderTest.CacheCombinationMatrix BE unit test, whose helper warms the query/searcher caches and asserts the expected hit/miss counters for the query-cache hit, query-cache disabled/searcher-cache hit, query-cache enabled/searcher-cache disabled, and both-disabled cases. StringTypeInvertedIndexReader::query() returns before handle_searcher_cache() on query-cache hits, matching the new assertion. be/test/CMakeLists.txt glob-includes this test file, and I found no stale references to the deleted regression suite outside the review bundle.
Critical checkpoints:
- Existing inline review context: live PR inline comments were empty, so there was no duplicate issue to suppress.
- User focus: no additional user-provided review focus was supplied.
- Regression/session coverage: existing SQL suites still exercise
enable_inverted_index_query_cacheandenable_inverted_index_searcher_cachepropagation; this PR's BE test covers the cache branch matrix deterministically. - Validation limits: static review only. The checkout is shallow and lacks the base commit locally, so GitHub PR file metadata was used as the authoritative diff. Local BE test execution was not possible because
thirdparty/installed,thirdparty/installed/bin/protoc, and a builtdoris_be_testbinary are missing. A path-limitedgit show --checkproduced no whitespace warnings.
Subagent conclusions: optimizer-rewrite found no optimizer/rewrite or semantic-equivalence candidate. tests-session-config found no regression, session/config, determinism, compatibility, or style candidate. Convergence round 1 ended with both live subagents replying NO_NEW_VALUABLE_FINDINGS for the final ledger/comment set.
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Proposed changes
Backport master PR #58137 to branch-4.1:
fault_injection_p0/test_inverted_index_cache.groovy.CacheCombinationMatrix, which covers the query/searcher cache hit/miss matrix.Root cause
The branch-4.1 x64 NonConcurrent case still runs an old debug-point regression test that master already removed in favor of BE UT coverage. The regression test can fail with an intentionally injected error when the runtime path reaches
InvertedIndexReader.handle_searcher_cache_miss.Failing example:
2012932000000108fault_injection_p0.test_inverted_index_cache.test_inverted_index_cache[INTERNAL_ERROR]handle searcher cache missValidation
86b9973e2bf/ PR [test](inverted index) remove regression case for inverted index cache, use ut instead #58137 was not inorigin/branch-4.1.git diff --check origin/branch-4.1...HEAD.Full BE UT was not run locally.