Skip to content

[fix](test) fix time series compaction rowset count#65342

Open
shuke987 wants to merge 1 commit into
apache:branch-4.1from
shuke987:fix-branch41-time-series-rowset-count
Open

[fix](test) fix time series compaction rowset count#65342
shuke987 wants to merge 1 commit into
apache:branch-4.1from
shuke987:fix-branch41-time-series-rowset-count

Conversation

@shuke987

@shuke987 shuke987 commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix compaction/test_time_series_compaction_level2.groovy rowset count assertions for branch-4.1 environments that force table replication to 3.

The test counts rowsets across every tablet replica returned by SHOW TABLETS. In the failing x64 branch-4.1 NonConcurrent build, force_olap_table_replication_num=3 overrides the case's replication_num=1, so the base rowset exists on each replica too. The previous assertions multiplied inserted/compacted rowsets by replicaNum but counted the base rowset only once, causing the first check to expect 31 while the actual rowset count is 33.

This patch applies replicaNum consistently to:

  • the per-round pre-compaction rowset count
  • the post-loop level-1 rowset count
  • the final base + level-2 rowset count

Testing

  • git diff --check
  • Checked TeamCity occurrence: build 201293, occurrence 2000000344
  • Runtime regression validation: pending run buildall

@shuke987 shuke987 requested a review from yiguolei as a code owner July 7, 2026 12:57
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

shuke987 commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

run buildall

1 similar comment
@shuke987

shuke987 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants