[fix](test) stabilize sql digest generation case#65343
Open
shuke987 wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated review completed for PR #65343.
Overall opinion: no blocking issue found. I reviewed the single changed regression test and the relevant audit/sql-digest/sleep-function paths. The change makes the audited query deterministically exceed sql_digest_generation_threshold_ms = 0 while still remaining far below the high-threshold branch, and I did not find a substantiated correctness or compatibility issue to raise inline.
Critical checkpoints:
- Changed files reviewed:
regression-test/suites/audit/test_sql_digest_generation.groovy. - Existing inline review context: no existing inline comments or replies were present, so no duplicate issue was suppressed from prior threads.
- User focus: no additional user-provided focus was supplied.
- Optimizer/rewrite correctness:
sleep(1)is a registered Nereids scalar function and the BE implementation avoids constant-time open-stage execution; no semantic rewrite issue found. - Tests/session/config behavior:
setFeConfigTemporaryrestores FE config, the low/high threshold assertions remain aligned withAuditLogHelper'selapseMs > sql_digest_generation_threshold_mscheck, and no expected-output or style issue was found. - Validation limits: static review only; the regression suite was not run locally in this runner.
git show --checkwas clean. Current GitHub checks include passing style/lightweight checks, with TeamCity compile and macOS BE UT still pending at review time.
Subagent conclusions:
optimizer-rewrite: no candidates appended; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.tests-session-config: no candidates appended; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.- No subagent candidate became an inline comment, and there were no duplicate candidate merges. Convergence ended in round 1 with all live subagents reporting
NO_NEW_VALUABLE_FINDINGSfor the same empty proposed final inline comment set.
Collaborator
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing