[fix](regression) fix full compaction run status case#65360
Open
shuke987 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated review completed for PR #65360.
I did not find a substantiated issue that needs an inline review comment. The PR is scoped to regression-test/suites/fault_injection_p0/test_full_compaciton_run_status.groovy and fixes the Groovy do ... while scoping problem by moving the compaction trigger tuple into variables declared outside the loop, so the loop condition reads the latest trigger response instead of resolving out outside its declaration scope.
Critical checkpoints:
- GitHub PR scope and live head were verified: head
b0f446a59cd27e653546d8266192463bae67539c, base7126cf65d96ebc43fce0906f51e92c1a2ccf24a6, one changed file. - Existing inline review context was empty, and there was no additional user-provided review focus.
- No AGENTS.md files were listed for this PR. The repo-local
.claude/skills/code-review/SKILL.mdfile was not present in this checkout, so I followed the review prompt and Doris review workflow gates. git diff --check 7126cf65d96ebc43fce0906f51e92c1a2ccf24a6 b0f446a59cd27e653546d8266192463bae67539c -- regression-test/suites/fault_injection_p0/test_full_compaciton_run_status.groovypassed.- I could not run the Groovy parse command or the full regression case in this runner because
groovyis not installed and the full case requires a live Doris regression environment with BE debug-point support. Current CI still had queued/pending checks at review time, including compile/code-review/BE UT macOS.
Subagent conclusions:
optimizer-rewritefound no optimizer/rewrite or semantic-equivalence candidate.tests-session-configfound no regression-test, expected-output, session/config, compatibility, or style candidate.- Final convergence round 1 completed with both live subagents replying
NO_NEW_VALUABLE_FINDINGSfor the empty proposed final comment set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_full_compaciton_run_status.runCode,runOut, andrunErrvariables so thedo ... whilecondition can parse the latest response instead of resolvingoutas a missingSuiteproperty.Testing
git diff --check -- regression-test/suites/fault_injection_p0/test_full_compaciton_run_status.groovygroovy -e "new GroovyShell().parse(new File('/Users/keshu/dudu/fix-cases/worktrees/doris-full-compaction-run-status-branch41/regression-test/suites/fault_injection_p0/test_full_compaciton_run_status.groovy'))"