Skip to content

[fix](regression) fix full compaction run status case#65360

Open
shuke987 wants to merge 1 commit into
apache:branch-4.1from
shuke987:fix-branch41-full-compaction-run-status
Open

[fix](regression) fix full compaction run status case#65360
shuke987 wants to merge 1 commit into
apache:branch-4.1from
shuke987:fix-branch41-full-compaction-run-status

Conversation

@shuke987

@shuke987 shuke987 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix the Groovy scope bug in test_full_compaciton_run_status.
  • Keep the full-compaction trigger response in loop-scoped runCode, runOut, and runErr variables so the do ... while condition can parse the latest response instead of resolving out as a missing Suite property.

Testing

  • git diff --check -- regression-test/suites/fault_injection_p0/test_full_compaciton_run_status.groovy
  • groovy -e "new GroovyShell().parse(new File('/Users/keshu/dudu/fix-cases/worktrees/doris-full-compaction-run-status-branch41/regression-test/suites/fault_injection_p0/test_full_compaciton_run_status.groovy'))"
  • Full regression case run, not run locally because it requires a live Doris regression environment with BE debug-point support.

@shuke987 shuke987 requested a review from yiguolei as a code owner July 8, 2026 06:44
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

shuke987 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

run buildall

@shuke987

shuke987 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review completed for PR #65360.

I did not find a substantiated issue that needs an inline review comment. The PR is scoped to regression-test/suites/fault_injection_p0/test_full_compaciton_run_status.groovy and fixes the Groovy do ... while scoping problem by moving the compaction trigger tuple into variables declared outside the loop, so the loop condition reads the latest trigger response instead of resolving out outside its declaration scope.

Critical checkpoints:

  • GitHub PR scope and live head were verified: head b0f446a59cd27e653546d8266192463bae67539c, base 7126cf65d96ebc43fce0906f51e92c1a2ccf24a6, one changed file.
  • Existing inline review context was empty, and there was no additional user-provided review focus.
  • No AGENTS.md files were listed for this PR. The repo-local .claude/skills/code-review/SKILL.md file was not present in this checkout, so I followed the review prompt and Doris review workflow gates.
  • git diff --check 7126cf65d96ebc43fce0906f51e92c1a2ccf24a6 b0f446a59cd27e653546d8266192463bae67539c -- regression-test/suites/fault_injection_p0/test_full_compaciton_run_status.groovy passed.
  • I could not run the Groovy parse command or the full regression case in this runner because groovy is not installed and the full case requires a live Doris regression environment with BE debug-point support. Current CI still had queued/pending checks at review time, including compile/code-review/BE UT macOS.

Subagent conclusions:

  • optimizer-rewrite found no optimizer/rewrite or semantic-equivalence candidate.
  • tests-session-config found no regression-test, expected-output, session/config, compatibility, or style candidate.
  • Final convergence round 1 completed with both live subagents replying NO_NEW_VALUABLE_FINDINGS for the empty proposed final comment set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants