Skip to content

[fix](regression) fail on compaction failure timestamp#65373

Open
shuke987 wants to merge 1 commit into
apache:masterfrom
shuke987:fix-compaction-failure-timestamp
Open

[fix](regression) fail on compaction failure timestamp#65373
shuke987 wants to merge 1 commit into
apache:masterfrom
shuke987:fix-compaction-failure-timestamp

Conversation

@shuke987

@shuke987 shuke987 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Proposed changes

Tighten trigger_and_wait_compaction so a changed compaction failure timestamp is not treated as successful completion.

The E-2010 cumulative-to-base handoff remains accepted only through the existing handoff success condition. For normal compaction paths, completion now still requires the target success timestamp to advance. If the compaction has stopped and only the failure timestamp advanced, the helper fails fast with the old/new tablet status.

Check List

  • git diff --check
  • Local Groovy condition simulation for success, failure-only, E-2010 waiting, and E-2010 completion paths

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

shuke987 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

/review

@shuke987

shuke987 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

run buildall

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Codex automated review failed and did not complete.

Error: You've hit your usage limit. Visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Jul 10th, 2026 6:44 AM.
Workflow run: https://github.com/apache/doris/actions/runs/28932415265

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants