[fix](regression) Drop view before its base tables in test_join5#65455
[fix](regression) Drop view before its base tables in test_join5#65455shuke987 wants to merge 1 commit into
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
/review |
There was a problem hiding this comment.
Reviewed the one-file regression cleanup in test_join5.groovy. The added DROP VIEW IF EXISTS ${tbName7}; runs after the last query that uses uqv1 and before the base tables are dropped, which matches the stated information_schema.view_dependency dangling-view hazard. The expected output remains correctly unchanged because the added statement has no result set.
Critical checkpoint conclusions:
- Goal/test proof: The PR is a focused cleanup for
test_join5; the existingqt_join4output remains covered bytest_join5.out, and the new statement is cleanup-only. - Scope: The change is small and isolated to one regression suite.
- Concurrency/lifecycle: No new runtime concurrency is introduced; the relevant concurrency point is that the suite no longer leaves a view visible after its base table cleanup begins.
- Compatibility/config/persistence/protocol: No FE/BE protocol, persisted format, session/config, or rolling-upgrade behavior changes.
- Parallel paths: No parallel changed path needs an update for this regression-only cleanup.
- Tests/results: The
.outfile is unchanged, which is appropriate becauseDROP VIEWproduces no query output.
User focus: No additional user-provided review focus was supplied.
Subagent conclusions: optimizer-rewrite found no optimizer, semantic-equivalence, join/aggregate, or view-planner candidate. tests-session-config found no regression-output, session/config, compatibility, or CI/style candidate. Convergence round 1 ended with both live subagents reporting NO_NEW_VALUABLE_FINDINGS for the same ledger/comment set, and no inline comments were accepted.
Validation limits: Static review only in this runner. The checkout is grafted/shallow, .worktree_initialized, thirdparty/installed, and output are absent, and groovy is not installed, so I did not run the regression suite locally. I did run git show --check --format=medium HEAD -- regression-test/suites/query_p0/join/test_join5.groovy, which reported no whitespace errors.
What problem does this PR solve?
Issue Number: DORIS-23587
Related PR: None
Problem Summary:
test_join5creates theuqv1view on top ofuq1, but dropsuq1while the view still exists. A concurrentinformation_schema.view_dependencyscan can observe this dangling view and fail while resolving its missing base table.This change drops
uqv1after its last assertion and before dropping its base tables, so the case does not expose an invalid intermediate state to concurrently running regression suites.Release note
None
Check List (For Author)
Test
git diff --checktest_join5.groovywithGroovyShell; result: PASS.Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)