[fix](be) Fix row binlog writer test metadata#65686
Merged
hello-stephen merged 1 commit intoJul 16, 2026
Merged
Conversation
### What problem does this PR solve? Issue Number: N/A Related PR: apache#65076, apache#65663 Problem Summary: The row-binlog writer BE unit test no longer compiles after allocate_binlog_lsn changed to accept a vector reference. After that compile error is fixed, the test aborts because its filtered row-binlog schema retains the metadata indexes from before two hidden columns were removed and its assertions still expect the previous LSN, operation, and timestamp layout. Initialize the LSN vector before passing it by reference, reset the TSO, LSN, and operation indexes after filtering, and verify values using the current metadata order and types. ### Release note None ### Check List (For Author) - Test: Unit Test - ./run-be-ut.sh --run '--filter=GroupRowsetWriterTest.*' - Behavior changed: No - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
approved these changes
Jul 16, 2026
Contributor
|
run beut |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
beut has passed, skip others |
Contributor
|
skip buildall |
gavinchou
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: #65076, #65663
Problem Summary:
The master BE unit test target fails to compile because
GroupRowsetWriterTeststill passes a pointer toallocate_binlog_lsn(), which now accepts a vector reference. After fixing compilation, the suite aborts while flushing row-binlog data.Root cause: In
GroupRowsetWriterTest.SetUp(), two columns are removed from the generated row-binlog schema without updatingbinlog_tso_idx,binlog_lsn_idx, andbinlog_op_idx.RowBinlogSegmentWriterconsequently accesses column ID 7 in a seven-column schema. The test output assertions also use the previous LSN, operation, and timestamp layout.This change initializes the shared LSN vector before passing it by reference, resets the metadata indexes after filtering columns, and verifies TSO, LSN, and operation values using the current schema order and types.
Release note
None
Check List (For Author)
Test
./run-be-ut.sh -j 20 --run '--filter=GroupRowsetWriterTest.*'(3 tests passed)Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)