Skip to content

[improvement](be) Add instance ID to hash join profiles#65761

Merged
HappenLee merged 1 commit into
apache:opt_perf_4.1from
HappenLee:opt_perf_4.1
Jul 17, 2026
Merged

[improvement](be) Add instance ID to hash join profiles#65761
HappenLee merged 1 commit into
apache:opt_perf_4.1from
HappenLee:opt_perf_4.1

Conversation

@HappenLee

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary: Shuffle hash join build and probe operators run in separate pipelines, so their per-instance profiles are difficult to correlate. Add the fragment instance ID to both hash join build and probe custom profiles. Profiles with the same join node ID and InstanceID now identify the corresponding build/probe pair without relying on process-local hash table addresses.

Release note

None

Check List (For Author)

  • Test: No need to test (profile-only metadata change; compilation was explicitly skipped)
    • Clang-format v16
    • git diff --check
  • Behavior changed: Yes (hash join build and probe profiles include InstanceID)
  • Does this need documentation: No

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

### What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary: Shuffle hash join build and probe operators run in separate pipelines, so their per-instance profiles are difficult to correlate. Add the fragment instance ID to both hash join build and probe custom profiles. Profiles with the same join node ID and InstanceID now identify the corresponding build/probe pair without relying on process-local hash table addresses.

### Release note

None

### Check List (For Author)

- Test: No need to test (profile-only metadata change; compilation was explicitly skipped)
    - Clang-format v16
    - git diff --check
- Behavior changed: Yes (hash join build and probe profiles include InstanceID)
- Does this need documentation: No
@HappenLee
HappenLee requested a review from yiguolei as a code owner July 17, 2026 08:12
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@HappenLee
HappenLee merged commit 3467a39 into apache:opt_perf_4.1 Jul 17, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants