Skip to content

[fix](table stream) min delta delete op should return first op's befo…#65826

Open
TsukiokaKogane wants to merge 3 commits into
apache:masterfrom
TsukiokaKogane:fix_min_delta_value
Open

[fix](table stream) min delta delete op should return first op's befo…#65826
TsukiokaKogane wants to merge 3 commits into
apache:masterfrom
TsukiokaKogane:fix_min_delta_value

Conversation

@TsukiokaKogane

@TsukiokaKogane TsukiokaKogane commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

…re value

What problem does this PR solve?

Issue Number: close #65800

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@TsukiokaKogane

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29516 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a07043c6ebf035f9968d69ff0b5acddb915f3a7c, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17941	4216	4227	4216
q2	2005	317	195	195
q3	10317	1368	847	847
q4	4692	470	338	338
q5	7500	843	579	579
q6	204	182	141	141
q7	774	822	613	613
q8	10304	1575	1603	1575
q9	5965	4354	4321	4321
q10	6759	1768	1454	1454
q11	516	358	324	324
q12	747	577	445	445
q13	18044	3223	2721	2721
q14	264	261	244	244
q15	q16	777	763	704	704
q17	944	873	907	873
q18	6849	5856	5612	5612
q19	1518	1260	1096	1096
q20	777	684	543	543
q21	5695	2666	2378	2378
q22	434	359	297	297
Total cold run time: 103026 ms
Total hot run time: 29516 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4562	4470	4523	4470
q2	294	319	219	219
q3	4569	4902	4406	4406
q4	2041	2153	1381	1381
q5	4467	4249	4325	4249
q6	235	185	141	141
q7	2109	1953	1620	1620
q8	2575	2149	2201	2149
q9	7831	7787	7746	7746
q10	4673	4722	4233	4233
q11	574	424	531	424
q12	742	786	531	531
q13	3355	3528	2984	2984
q14	304	325	296	296
q15	q16	714	728	643	643
q17	1370	1349	1409	1349
q18	7972	7421	6886	6886
q19	1100	1052	1062	1052
q20	2199	2231	1936	1936
q21	5231	4620	4365	4365
q22	516	466	395	395
Total cold run time: 57433 ms
Total hot run time: 51475 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 177298 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a07043c6ebf035f9968d69ff0b5acddb915f3a7c, data reload: false

query5	4376	659	492	492
query6	475	219	213	213
query7	4871	599	338	338
query8	342	204	174	174
query9	8783	4055	4035	4035
query10	491	348	318	318
query11	5879	2305	2113	2113
query12	155	97	99	97
query13	1247	588	425	425
query14	6243	5192	4859	4859
query14_1	4263	4264	4273	4264
query15	222	200	177	177
query16	1002	484	447	447
query17	951	728	586	586
query18	2448	488	350	350
query19	212	191	153	153
query20	113	115	108	108
query21	236	172	140	140
query22	13659	13585	13277	13277
query23	17354	16435	16152	16152
query23_1	16420	16154	16433	16154
query24	7502	1747	1277	1277
query24_1	1325	1294	1268	1268
query25	577	473	390	390
query26	1334	365	223	223
query27	2571	612	391	391
query28	4492	1975	1964	1964
query29	1087	636	485	485
query30	340	277	230	230
query31	1112	1094	987	987
query32	113	66	64	64
query33	524	331	257	257
query34	1194	1118	630	630
query35	767	787	685	685
query36	1205	1199	1035	1035
query37	160	108	96	96
query38	1890	1697	1637	1637
query39	884	883	841	841
query39_1	828	846	838	838
query40	248	167	141	141
query41	75	69	69	69
query42	94	96	92	92
query43	329	325	286	286
query44	1404	787	765	765
query45	199	181	180	180
query46	1073	1210	746	746
query47	2095	2119	2003	2003
query48	409	430	263	263
query49	590	430	316	316
query50	1093	436	335	335
query51	10975	10981	10768	10768
query52	90	92	77	77
query53	269	269	209	209
query54	296	252	249	249
query55	75	77	70	70
query56	318	322	295	295
query57	1303	1292	1195	1195
query58	310	299	248	248
query59	1567	1650	1391	1391
query60	310	269	250	250
query61	152	143	146	143
query62	552	495	427	427
query63	241	202	203	202
query64	2843	1065	881	881
query65	4625	4490	4620	4490
query66	1866	502	379	379
query67	28676	29260	29113	29113
query68	3154	1504	930	930
query69	419	311	267	267
query70	1084	1005	963	963
query71	378	340	311	311
query72	3037	2677	2405	2405
query73	837	769	435	435
query74	5021	4898	4734	4734
query75	2537	2487	2125	2125
query76	2339	1178	772	772
query77	353	387	287	287
query78	11880	11786	11249	11249
query79	1436	1177	741	741
query80	1322	563	485	485
query81	528	327	281	281
query82	600	160	118	118
query83	376	335	295	295
query84	323	158	127	127
query85	972	600	506	506
query86	426	284	272	272
query87	1830	1821	1746	1746
query88	3679	2763	2746	2746
query89	450	370	332	332
query90	1942	203	207	203
query91	203	195	164	164
query92	64	62	55	55
query93	1690	1491	1049	1049
query94	736	362	308	308
query95	779	514	579	514
query96	1130	775	355	355
query97	2633	2625	2512	2512
query98	212	209	205	205
query99	1086	1113	980	980
Total cold run time: 263549 ms
Total hot run time: 177298 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 24.94 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a07043c6ebf035f9968d69ff0b5acddb915f3a7c, data reload: false

query1	0.00	0.00	0.00
query2	0.09	0.04	0.04
query3	0.25	0.13	0.13
query4	1.61	0.14	0.14
query5	0.24	0.23	0.21
query6	1.22	1.09	1.08
query7	0.04	0.01	0.01
query8	0.05	0.03	0.03
query9	0.37	0.33	0.31
query10	0.56	0.56	0.54
query11	0.18	0.13	0.13
query12	0.18	0.14	0.15
query13	0.47	0.47	0.47
query14	1.05	1.01	1.01
query15	0.62	0.59	0.60
query16	0.31	0.32	0.32
query17	1.11	1.12	1.09
query18	0.23	0.21	0.21
query19	1.97	1.99	1.95
query20	0.01	0.01	0.01
query21	15.43	0.20	0.13
query22	4.81	0.05	0.06
query23	16.11	0.30	0.12
query24	3.00	0.38	0.29
query25	0.11	0.05	0.04
query26	0.74	0.20	0.16
query27	0.04	0.04	0.04
query28	3.54	0.90	0.55
query29	12.48	4.08	3.27
query30	0.28	0.16	0.15
query31	2.77	0.55	0.30
query32	3.23	0.59	0.49
query33	3.21	3.12	3.20
query34	15.55	4.22	3.51
query35	3.54	3.51	3.51
query36	0.58	0.43	0.43
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.04	0.02	0.03
query40	0.18	0.16	0.16
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 96.52 s
Total hot run time: 24.94 s

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.54% (24007/41723)
Line Coverage 41.25% (236201/572540)
Region Coverage 37.08% (186685/503495)
Branch Coverage 38.29% (83898/219107)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.68% (29987/40698)
Line Coverage 57.44% (326835/569011)
Region Coverage 53.53% (270509/505384)
Branch Coverage 54.78% (120109/219249)

gavinchou
gavinchou previously approved these changes Jul 21, 2026
@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jul 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions Bot removed the approved Indicates a PR has been approved by one committer. label Jul 21, 2026
@TsukiokaKogane

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29781 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f394c611e0a3d831eb0b2f5ce1bc7c7d4fe3f3b8, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17702	4277	4188	4188
q2	2056	340	201	201
q3	10225	1500	849	849
q4	4717	519	347	347
q5	7765	869	566	566
q6	245	186	141	141
q7	825	826	614	614
q8	10524	1576	1699	1576
q9	5980	4392	4380	4380
q10	6830	1780	1455	1455
q11	520	364	318	318
q12	744	612	452	452
q13	18211	3493	2718	2718
q14	285	266	250	250
q15	q16	787	785	702	702
q17	987	1025	1078	1025
q18	6999	5664	5589	5589
q19	1177	1242	1098	1098
q20	808	713	579	579
q21	5542	2719	2433	2433
q22	442	363	300	300
Total cold run time: 103371 ms
Total hot run time: 29781 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4587	4519	4534	4519
q2	315	350	209	209
q3	4736	5080	4445	4445
q4	2339	2386	1382	1382
q5	4638	4516	4967	4516
q6	278	215	147	147
q7	2080	1851	1776	1776
q8	2691	2328	2384	2328
q9	8171	7983	8032	7983
q10	4960	4842	4302	4302
q11	616	420	379	379
q12	795	807	555	555
q13	3455	3809	2981	2981
q14	320	327	283	283
q15	q16	739	745	672	672
q17	1420	1387	1423	1387
q18	8378	7674	7026	7026
q19	1092	1110	1083	1083
q20	2252	2240	1921	1921
q21	5607	4802	4584	4584
q22	551	457	420	420
Total cold run time: 60020 ms
Total hot run time: 52898 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 177923 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f394c611e0a3d831eb0b2f5ce1bc7c7d4fe3f3b8, data reload: false

query5	4322	624	502	502
query6	479	223	203	203
query7	4850	595	347	347
query8	357	198	174	174
query9	8766	4030	4046	4030
query10	454	381	339	339
query11	5925	2337	2148	2148
query12	161	105	103	103
query13	1253	610	438	438
query14	6263	5212	4879	4879
query14_1	4249	4262	4241	4241
query15	213	205	190	190
query16	1092	493	454	454
query17	1150	724	594	594
query18	2538	482	355	355
query19	217	192	155	155
query20	116	111	109	109
query21	241	166	143	143
query22	13586	13611	13256	13256
query23	17453	16380	16149	16149
query23_1	16267	16202	16164	16164
query24	7537	1738	1309	1309
query24_1	1308	1296	1305	1296
query25	578	456	388	388
query26	1345	381	222	222
query27	2591	571	378	378
query28	4461	1985	1945	1945
query29	1089	643	505	505
query30	356	265	229	229
query31	1119	1105	979	979
query32	128	66	63	63
query33	545	330	270	270
query34	1212	1115	624	624
query35	780	798	683	683
query36	1165	1215	1058	1058
query37	164	113	93	93
query38	1862	1715	1659	1659
query39	877	872	852	852
query39_1	832	831	846	831
query40	281	166	190	166
query41	66	66	65	65
query42	92	92	90	90
query43	319	319	273	273
query44	1406	760	752	752
query45	202	183	174	174
query46	1041	1209	757	757
query47	2168	2091	1965	1965
query48	427	435	306	306
query49	583	414	307	307
query50	1182	446	332	332
query51	10952	10864	11036	10864
query52	88	88	75	75
query53	269	280	201	201
query54	280	231	211	211
query55	73	70	66	66
query56	300	316	293	293
query57	1320	1291	1203	1203
query58	290	258	271	258
query59	1574	1618	1457	1457
query60	324	272	256	256
query61	147	149	146	146
query62	547	491	430	430
query63	245	203	201	201
query64	2816	1027	912	912
query65	4721	4643	4600	4600
query66	1827	516	388	388
query67	29255	29137	29090	29090
query68	3134	1524	1016	1016
query69	412	305	269	269
query70	1093	983	951	951
query71	366	335	329	329
query72	2995	2611	2373	2373
query73	868	796	439	439
query74	5040	4921	4730	4730
query75	2545	2521	2117	2117
query76	2300	1175	771	771
query77	343	380	273	273
query78	11729	11820	11331	11331
query79	1471	1135	756	756
query80	1287	556	472	472
query81	564	335	285	285
query82	751	152	119	119
query83	358	323	312	312
query84	300	160	130	130
query85	953	600	571	571
query86	431	285	281	281
query87	1813	1824	1741	1741
query88	3667	2755	2746	2746
query89	439	382	325	325
query90	1855	195	192	192
query91	203	193	165	165
query92	66	59	58	58
query93	1674	1573	985	985
query94	710	339	328	328
query95	806	590	469	469
query96	1014	761	356	356
query97	2630	2621	2525	2525
query98	211	204	194	194
query99	1084	1115	960	960
Total cold run time: 264126 ms
Total hot run time: 177923 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 24.85 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f394c611e0a3d831eb0b2f5ce1bc7c7d4fe3f3b8, data reload: false

query1	0.00	0.00	0.00
query2	0.09	0.05	0.05
query3	0.25	0.14	0.13
query4	1.61	0.14	0.14
query5	0.24	0.21	0.22
query6	1.24	1.06	1.03
query7	0.04	0.00	0.00
query8	0.06	0.04	0.03
query9	0.38	0.30	0.32
query10	0.53	0.54	0.54
query11	0.20	0.13	0.13
query12	0.18	0.14	0.14
query13	0.47	0.47	0.47
query14	1.01	1.01	1.01
query15	0.63	0.59	0.59
query16	0.30	0.34	0.31
query17	1.10	1.13	1.06
query18	0.22	0.20	0.20
query19	2.08	1.99	1.91
query20	0.02	0.01	0.01
query21	15.42	0.22	0.13
query22	4.84	0.05	0.05
query23	16.16	0.31	0.12
query24	2.95	0.45	0.35
query25	0.12	0.04	0.04
query26	0.74	0.20	0.14
query27	0.05	0.03	0.05
query28	3.48	0.97	0.50
query29	12.50	4.07	3.29
query30	0.29	0.15	0.16
query31	2.77	0.61	0.30
query32	3.22	0.59	0.49
query33	3.19	3.31	3.17
query34	15.56	4.22	3.49
query35	3.52	3.54	3.55
query36	0.55	0.46	0.43
query37	0.08	0.06	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.02
query40	0.18	0.16	0.16
query41	0.08	0.03	0.04
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.53 s
Total hot run time: 24.85 s

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.65% (29974/40698)
Line Coverage 57.41% (326703/569031)
Region Coverage 53.59% (270845/505405)
Branch Coverage 54.76% (120070/219259)

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jul 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] MIN_DELTA stream returns the wrong value after UPDATE followed by DELETE

3 participants