[fix](variant) Apply sparse/doc mixed-row review fixes#65957
[fix](variant) Apply sparse/doc mixed-row review fixes#65957hello-stephen wants to merge 1 commit into
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#65660 Problem Summary: The merged sparse VARIANT visibility fix still used a cumulative doc-value end offset, so doc data from an earlier row could hide sparse fields in the current row. Its regression oracle also retained two rows whose empty objects were rendered as arrays. Use the current-row doc-value offset delta, add the prior-doc/current-sparse unit scenario, and remove the unrelated bad oracle rows. ### Release note None ### Check List (For Author) - Test: clang-format 16 check, git diff --check, and Groovy syntax/discovery check passed. BE UT and buildall are required in CI. - Behavior changed: Yes. Current-row sparse fields are no longer hidden by a previous row doc snapshot. - Does this need documentation: No
|
run buildall |
|
/review |
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
Codex automated review failed and did not complete. Error: You've hit your usage limit. Visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Jul 28th, 2026 5:08 PM. Please inspect the workflow logs and rerun the review after the underlying issue is resolved. |
TPC-H: Total hot run time: 29615 ms |
TPC-DS: Total hot run time: 178184 ms |
ClickBench: Total hot run time: 25.02 s |
|
[nonconcurrent-1003981-shared-agent-failure] NonConcurrent build #1003981 is terminal FAILURE, but its 51 failed cases are one startup cascade rather than independent case failures. First actionable error in the uploaded BE log occurs before any case runs: the BE bundled Python environment cannot be created because This build ran on agent Please rerun NonConcurrent on a clean agent (or repair the missing Python venv dependency on this agent) and use that terminal result for the PR gate. |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
What problem does this PR solve?
Issue Number: None
Related PR: #65660
Problem Summary:
PR #65660 was merged before its separate review follow-up could land. Two correctness items therefore remain on master:
This PR reapplies only the four-file review follow-up on top of current master. It uses the current-row doc-value offset delta, adds the prior-doc/current-sparse unit scenario, and removes the two unrelated oracle rows.
Release note
None
Check List (For Author)
build-support/clang-format.shandbuild-support/check-format.shwith clang-format 16 passed.git diff --checkpassed.test_topn_lazy_materialize_sparse_variantin groupp0.thirdparty/installed/bin/thrift; BE UT and buildall are required in CI.