branch-4.0: [fix](cloud) Fix SchemaVariablesScanner crash due to incomplete FE response #65994#66014
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](cloud) Fix SchemaVariablesScanner crash due to incomplete FE response #65994#66014github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…sponse (#65994) Problem Summary: When the Thrift connection to FE is unstable, a partially deserialized TShowVariableResult can contain variable rows with fewer than four fields. SchemaVariablesScanner accessed fields 0 through 3 unconditionally and could crash the BE process. Validate every row before accessing its fields and return an InternalError asking the user to retry when the response is incomplete. ### Release note Fix a BE crash when scanning variables after receiving an incomplete FE response; the query now returns an error asking the user to retry.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #65994