branch-4.1: [opt](scan) Schedule scanners up to max concurrency - #66106
Closed
HappenLee wants to merge 1 commit into
Closed
branch-4.1: [opt](scan) Schedule scanners up to max concurrency#66106HappenLee wants to merge 1 commit into
HappenLee wants to merge 1 commit into
Conversation
(cherry picked from commit 2903457)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: Cherry-pick "Schedule scanners up to max concurrency" from opt_perf_4.1 (commit 2903457) to branch-4.1.
Previously
ScannerContext::_get_margincomputed two margins (per-scan-operator_min_scan_concurrencyguarantee and scheduler-level_min_scan_concurrency_of_scan_schedulerguarantee) and took the max, which under-utilizes scan concurrency. This change schedules scanners directly up to_max_scan_concurrency(_max_scan_concurrency - _num_scheduled_scanners), keeping the low-memory-mode cap, so scanners are scheduled at full concurrency and scan performance improves.Release note
None
Check List (For Author)