Skip to content

[feature](ci) Rotate review credentials after quota errors - #66111

Closed
wzz6423 wants to merge 1 commit into
apache:masterfrom
wzz6423:feat/code-review-account-quota-rotation-upstream
Closed

[feature](ci) Rotate review credentials after quota errors#66111
wzz6423 wants to merge 1 commit into
apache:masterfrom
wzz6423:feat/code-review-account-quota-rotation-upstream

Conversation

@wzz6423

@wzz6423 wzz6423 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary: Code review jobs selected credentials randomly and could not retain quota, rate-limit, or authentication-failure state across runs. This change persists account state in object storage, initializes the state object when it is absent, rotates after account-specific failures, and retries transient service failures with exponential backoff.

Release note

Code review jobs now rotate credentials based on persisted availability and send an alert when both accounts exhaust quota.

Check List (For Author)

  • Test: Unit Test
    • Python unit tests for state initialization, rotation, cooldown recovery, failure classification, and alert eligibility
    • Workflow YAML and Bash syntax validation
    • State helper command-line flow validation
  • Behavior changed: Yes (credential selection and retry behavior are persisted across code review jobs)
  • Does this need documentation: No

### What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary: Code review jobs selected credentials randomly and could not retain quota or rate-limit state across runs. Persist account status in object storage, rotate immediately after account-specific failures, and retry transient service failures with exponential backoff.

### Release note

Code review jobs now rotate credentials based on persisted availability and send an alert when both accounts exhaust quota.

### Check List (For Author)

- Test: Unit Test
    - Python unit tests for state initialization, rotation, cooldown recovery, failure classification, and alert eligibility
    - Workflow YAML and Bash syntax validation
- Behavior changed: Yes (credential selection and retry behavior are persisted across code review jobs)
- Does this need documentation: No
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

Copy link
Copy Markdown
Contributor

/review

@github-actions

Copy link
Copy Markdown
Contributor

Codex automated review failed and did not complete.

Error: You've hit your usage limit. Visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Aug 2nd, 2026 1:27 AM.
Workflow run: https://github.com/apache/doris/actions/runs/30259990434

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

@wzz6423

wzz6423 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #66119.

@wzz6423 wzz6423 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants