Skip to content

branch-4.0:[fix](filecache) Limit LRU recorder shadow queue size(pick#64798) - #66128

Merged
morningman merged 1 commit into
apache:branch-4.0from
freemandealer:pick-branch-4.0-pr-64798
Jul 28, 2026
Merged

branch-4.0:[fix](filecache) Limit LRU recorder shadow queue size(pick#64798)#66128
morningman merged 1 commit into
apache:branch-4.0from
freemandealer:pick-branch-4.0-pr-64798

Conversation

@freemandealer

@freemandealer freemandealer commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: N/A

Related PR: #64798

Problem Summary: Pick #64798 into branch-4.0.

Release note

None

Check List (For Author)

  • Test:
    • Format: build-support/clang-format.sh and build-support/check-format.sh passed.
    • BE: JAVA_HOME=/mnt/disk1/zhangzhengyu/build-dep/jdk-17.0.2/ DORIS_TOOLCHAIN=clang DISABLE_BE_JAVA_EXTENSIONS=ON ENABLE_INJECTION_POINT=ON ENABLE_CACHE_LOCK_DEBUG=0 ENABLE_PCH=0 ./build.sh --be
    • BE UT: same environment, sh run-be-ut.sh --run --filter=CacheLRUDumperTest.*
  • Behavior changed: No
  • Does this need documentation: No

@freemandealer

freemandealer commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

hello-stephen commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer

freemandealer commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

run beut

@freemandealer

freemandealer commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

run nonConcurrent

@freemandealer
[fix](filecache) Limit LRU recorder shadow queue size
e024566 
Issue Number: None

Related PR: selectdb/selectdb-core#9858

Problem Summary: The file cache LRU recorder can replay more records into the shadow queue than the configured dump-tail limit, allowing the shadow queue to keep growing after long-running replay. This change trims replayed shadow queues to file_cache_background_lru_dump_tail_record_num, exposes shadow queue element counts in file cache stats, and adds BE UT coverage for tail retention, remove-event trimming, metric refresh, and replay queue cap behavior.

None

- Test: Build and unit test
    - Build: DORIS_TOOLCHAIN=clang DISABLE_BE_JAVA_EXTENSIONS=ON ENABLE_INJECTION_POINT=ON ENABLE_CACHE_LOCK_DEBUG=0 ENABLE_PCH=0 ./build.sh --be
    - Unit Test: DORIS_TOOLCHAIN=clang DISABLE_BE_JAVA_EXTENSIONS=ON ENABLE_INJECTION_POINT=ON ENABLE_CACHE_LOCK_DEBUG=0 ENABLE_PCH=0 sh run-be-ut.sh --run --filter=CacheLRUDumperTest.*
- Behavior changed: Yes. The LRU recorder shadow queue is capped by file_cache_background_lru_dump_tail_record_num during replay.
- Does this need documentation: No
@freemandealer
freemandealer force-pushed the pick-branch-4.0-pr-64798 branch from aa95eaf to e024566 Compare July 28, 2026 07:55
@freemandealer

freemandealer commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

run buildall

@morningman
morningman merged commit 8b29ca3 into apache:branch-4.0 Jul 28, 2026
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@freemandealer @hello-stephen @morningman