[chore](recycler) Disable enable_mark_delete_rowset_before_recycle and enable_abort_txn_and_job_for_delete_rowset_before_recycle for recycler - #66150
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
I found one blocking data-correctness issue in the recycler default change.
Critical checkpoint conclusions:
- Goal and proof: The diff changes the two recycler switches to false and adapts tests, but the lifecycle tests force the previous true/true behavior and do not prove the new default is safe.
- Scope and clarity: The source diff is small, but it changes a correctness-sensitive ownership protocol without an equivalent fence or rationale in the PR description.
- Concurrency: Blocking issue found. PREPARE-to-tmp promotion can race with queued file deletion, and an eventual COMMITTED transaction can lose its tmp rows before lazy finalization and still become VISIBLE.
- Lifecycle/static initialization: The relevant non-intuitive lifecycle is eventual commit followed by TxnLazyCommitTask; no separate static-initialization or object-lifetime issue was found.
- Configuration: Both switches are mutable and observed by recycler scans; making false the production default removes mark-before-delete and abort-before-delete from ordinary non-versioned recycling.
- Compatibility and parallel paths: No wire/storage-format incompatibility was found. Both non-versioned recycle_rowsets and recycle_tmp_rowsets are affected; versioned recycling follows a separate path.
- Conditional/error handling: No separate condition or error-propagation bug was found beyond the missing ownership fence.
- Tests/results: The shortened batching test has internally correct 5 -> 3 -> 1 -> 0 behavior. All nine changed lifecycle tests force true/true, and none deterministically covers the false/false ownership races. I did not run builds or tests because this review runner explicitly forbids them.
- Observability: Existing logs are sufficient to trace these paths; no separate observability blocker was found.
- Persistence and data writes: The accepted inline finding can make a transaction VISIBLE after its rowset data has been deleted, violating data correctness. No EditLog path or new cross-process FE/BE variable is involved in this cloud KV change.
- Performance: No distinct performance regression was substantiated in the reviewed diff.
User focus: No additional user-provided focus was specified.
Review completion: The full three-file diff and upstream/downstream paths were reviewed. Three rounds of normal and risk-focused review converged; every Round 3 agent returned NO_NEW_VALUABLE_FINDINGS against the frozen comment set, and no suspicious point remains unresolved.
Contributor
|
PR approved by at least one committer and no changes requested. |
wyxxxcat
added a commit
to wyxxxcat/doris
that referenced
this pull request
Jul 29, 2026
…and `enable_abort_txn_and_job_for_delete_rowset_before_recycle` for recycler (apache#66150)
wyxxxcat
added a commit
to wyxxxcat/doris
that referenced
this pull request
Jul 29, 2026
…and `enable_abort_txn_and_job_for_delete_rowset_before_recycle` for recycler (apache#66150)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)