[chore]Remove Hastyshell from collaborators list - #66161
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
/review |
There was a problem hiding this comment.
Automated review summary for 8c81da6d55a1f39ca21b846060b671294921529a
Opinion: the .asf.yaml change itself is correct, minimal, and has no critical code/configuration defect. I found no valid inline issue. One non-inline merge gate remains: the PR title and sole commit headline, [chore]Remove Hastyshell from collaborators list, omit the required (module) segment. The live PR title checker fails the repository regex for exactly this reason. Please use a compliant title such as [chore](asf) Remove Hastyshell from collaborators list.
Critical checkpoint conclusions:
- Goal and proof: the single deletion uses ASF's documented external-collaborator removal mechanism. The upstream reconciler computes the removed login set and calls GitHub's collaborator-removal API. Live state resolves
Hastyshellto the currently configured direct outside collaborator withtriageaccess and nopushaccess. - Scope and clarity: the authoritative diff changes only this one list entry. The resulting YAML parses successfully and leaves seven unique, non-empty collaborator IDs, below ASF's limit of ten.
- Concurrency and lifecycle: no Doris threads, locks, atomics, static initialization, memory ownership, or runtime object lifecycle is involved. The only lifecycle is ASF's post-merge default-branch reconciliation.
- Configuration and compatibility: this removes an entry from an existing repository-governance setting; it adds no Doris dynamic configuration. There is no FE/BE/cloud protocol, symbol, serialization, storage-format, rolling-upgrade, or parallel runtime path impact.
- Testing and results: kernel/regression/unit tests are not applicable to this metadata-only deletion. Review validation parsed the complete YAML and checked list shape, uniqueness, and count. Broad CI checks succeeded or were skipped for this scope; the title-specific check is the known failure described above. No test result artifact changed.
- Observability, persistence, data safety, and performance: no Doris logging/metrics, EditLog, transaction, data-write, crash-atomicity, memory, CPU, or I/O behavior changes.
- Security/governance: this is repository access governance, not a Doris runtime vulnerability under the project threat model. The technical mechanism and exact principal are verified; the project/PMC authorization for removing the grant remains a maintainer governance decision.
- User focus and convergence: no additional review focus was supplied, so the whole PR was reviewed. Two review rounds completed; the final normal and risk-focused passes both returned
NO_NEW_VALUABLE_FINDINGS, and every candidate was adjudicated.
Current delivery state: the PR is closed and unmerged at the reviewed head. master still lists Hastyshell, and the live permission remains triage, so this PR has not revoked access. If the change is still intended, reopen it, correct the title, confirm the governance decision, and merge it so ASF reconciliation can apply the removal.
No description provided.