[fix](compaction) Fix sparse vertical compaction destination offset - #66306
Open
Yukang-Lian wants to merge 1 commit into
Open
[fix](compaction) Fix sparse vertical compaction destination offset#66306Yukang-Lian wants to merge 1 commit into
Yukang-Lian wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Yukang-Lian
marked this pull request as ready for review
July 31, 2026 02:47
Yukang-Lian
requested review from
gavinchou,
luwei16 and
yiguolei
as code owners
July 31, 2026 02:47
Collaborator
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29438 ms |
Contributor
TPC-DS: Total hot run time: 178867 ms |
Contributor
ClickBench: Total hot run time: 24.93 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
BOOLEANcolumn followed by a nullable fixed-widthBIGINTcolumn in the same value group.Why
The leading value column may reserve capacity without increasing its size. Deriving the destination offset from its post-prepare size can therefore select the wrong position.