Skip to content

branch-4.0: [chore](session-variable) remove the unused session variable plan_nereids_dump - #66386

Merged
morningman merged 1 commit into
apache:branch-4.0from
CalvinKirs:4.0-66371
Aug 4, 2026
Merged

branch-4.0: [chore](session-variable) remove the unused session variable plan_nereids_dump#66386
morningman merged 1 commit into
apache:branch-4.0from
CalvinKirs:4.0-66371

Conversation

@CalvinKirs

Copy link
Copy Markdown
Member

…ble plan_nereids_dump

Cherry-pick of apache#66371.

Adapted for branch-4.0: this branch has no VariableMgr.REMOVED_SESSION_VAR_NAMES
compatibility list, so only the SessionVariable part is picked. `SET plan_nereids_dump
= ...` therefore reports ERR_UNKNOWN_SYSTEM_VARIABLE on this branch instead of being
silently ignored. Replaying an old global-variable edit log or image entry is
unaffected: VariableMgr.replayGlobalVariableV2 logs and skips unknown variable names.

(cherry picked from commit e308b6a)
@CalvinKirs
CalvinKirs requested a review from morningman as a code owner August 3, 2026 11:48
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit 7e1bc57 into apache:branch-4.0 Aug 4, 2026
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants