Skip to content

[chore](workflow)Delete .github/workflows/code-checks.yml - #66404

Merged
morningman merged 1 commit into
masterfrom
CalvinKirs-patch-9
Aug 4, 2026
Merged

[chore](workflow)Delete .github/workflows/code-checks.yml#66404
morningman merged 1 commit into
masterfrom
CalvinKirs-patch-9

Conversation

@CalvinKirs

@CalvinKirs CalvinKirs commented Aug 4, 2026

Copy link
Copy Markdown
Member

This workflow is no longer needed.

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs

Copy link
Copy Markdown
Member Author

/review

@CalvinKirs

Copy link
Copy Markdown
Member Author

run buildall

@morningman
morningman merged commit ac0698d into master Aug 4, 2026
33 of 34 checks passed

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Request changes: the workflow removal leaves a tracked shell-check entry point broken. The PR merged externally while this review was converging; this finding still applies to the merged code.

Critical checkpoints

  • Goal and functional completeness: The dormant workflow is removed, but the cleanup is incomplete because build-support/shell-check.sh depends on the deleted exclusion list. The repository's surviving shell-check entry point no longer remains functional.
  • Scope and parallel paths: The one-file deletion is narrow, but it misses the only exact-path consumer of the deleted file. The live protected-branch list confirms that none of the Code Checks, ShellCheck, Clang Tidy Preparation, or Clang Tidy contexts is required, so there is no separate merge-gating finding.
  • Concurrency, lifecycle, configuration, and compatibility: No runtime concurrency, storage, protocol, transaction, persistence, FE-BE transport, or dynamic-configuration path applies. The workflow was already manually disabled; the compatibility regression is confined to the surviving local helper.
  • Conditions and validation: The missing file makes the helper's grep fail under set -eo pipefail; the process-substitution/read path then exits with status 1 before ShellCheck or shfmt runs. No PR smoke check covers this surviving entry point. Per the review-run contract, no build or repository test was run.
  • Observability and performance: The regression emits an immediate missing-file diagnostic; no additional observability or performance issue was found.
  • User focus: review_focus.txt supplied no additional focus, so the whole PR was reviewed without narrowing scope.
  • Review completion: One normal full-review subagent and one separate risk-focused subagent both returned NO_NEW_VALUABLE_FINDINGS after independently confirming only the accepted duplicate. No candidate remains unresolved for head d4ab0709314104c1a44ba5aa3945518e34af17e9.

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
sh_checker_comment: true
sh_checker_exclude: .git .github ^docker/compilation ^docker/runtime ^thirdparty/src ^thirdparty/installed ^ui ^docs/node_modules ^tools/clickbench-tools ^extension ^output (^|.*/)Dockerfile$ ^be/src/apache-orc ^be/src/clucene ^pytest ^samples

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build-support/shell-check.sh still reads this exact sh_checker_exclude line from .github/workflows/code-checks.yml in find_shell_scripts(). Once this file is deleted, that grep hits a missing file and, under the helper's set -e, the helper exits before running ShellCheck or shfmt. Please move the exclusions into a surviving config/script and update build-support/shell-check.sh in this PR so the repository's shell-check entry point remains usable.

@CalvinKirs
CalvinKirs deleted the CalvinKirs-patch-9 branch August 4, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants