[chore](workflow)Delete .github/workflows/code-checks.yml - #66404
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
/review |
|
run buildall |
There was a problem hiding this comment.
Review summary
Request changes: the workflow removal leaves a tracked shell-check entry point broken. The PR merged externally while this review was converging; this finding still applies to the merged code.
Critical checkpoints
- Goal and functional completeness: The dormant workflow is removed, but the cleanup is incomplete because
build-support/shell-check.shdepends on the deleted exclusion list. The repository's surviving shell-check entry point no longer remains functional. - Scope and parallel paths: The one-file deletion is narrow, but it misses the only exact-path consumer of the deleted file. The live protected-branch list confirms that none of the
Code Checks,ShellCheck,Clang Tidy Preparation, orClang Tidycontexts is required, so there is no separate merge-gating finding. - Concurrency, lifecycle, configuration, and compatibility: No runtime concurrency, storage, protocol, transaction, persistence, FE-BE transport, or dynamic-configuration path applies. The workflow was already manually disabled; the compatibility regression is confined to the surviving local helper.
- Conditions and validation: The missing file makes the helper's
grepfail underset -eo pipefail; the process-substitution/read path then exits with status 1 before ShellCheck or shfmt runs. No PR smoke check covers this surviving entry point. Per the review-run contract, no build or repository test was run. - Observability and performance: The regression emits an immediate missing-file diagnostic; no additional observability or performance issue was found.
- User focus:
review_focus.txtsupplied no additional focus, so the whole PR was reviewed without narrowing scope. - Review completion: One normal full-review subagent and one separate risk-focused subagent both returned
NO_NEW_VALUABLE_FINDINGSafter independently confirming only the accepted duplicate. No candidate remains unresolved for headd4ab0709314104c1a44ba5aa3945518e34af17e9.
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| sh_checker_comment: true | ||
| sh_checker_exclude: .git .github ^docker/compilation ^docker/runtime ^thirdparty/src ^thirdparty/installed ^ui ^docs/node_modules ^tools/clickbench-tools ^extension ^output (^|.*/)Dockerfile$ ^be/src/apache-orc ^be/src/clucene ^pytest ^samples |
There was a problem hiding this comment.
build-support/shell-check.sh still reads this exact sh_checker_exclude line from .github/workflows/code-checks.yml in find_shell_scripts(). Once this file is deleted, that grep hits a missing file and, under the helper's set -e, the helper exits before running ShellCheck or shfmt. Please move the exclusions into a surviving config/script and update build-support/shell-check.sh in this PR so the repository's shell-check entry point remains usable.
This workflow is no longer needed.