Skip to content

branch-4.1: [fix](regression) Stabilize initial rowset visibility check #66267 - #66454

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66267-branch-4.1
Aug 5, 2026
Merged

branch-4.1: [fix](regression) Stabilize initial rowset visibility check #66267#66454
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66267-branch-4.1

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #66267

### What problem does this PR solve?

Issue Number: None

Problem Summary: `information_schema.rowsets` is a distributed BE
snapshot and can briefly return an incomplete result immediately after
table creation. The regression test queried it only once, so the initial
`[0, 1]` rowset assertion could fail intermittently even though table
creation had completed successfully.

### What is changed?

- Poll for up to 30 seconds until the system table observes the
synchronously created `[0, 1]` rowset.
- Keep the existing golden query after the wait, so the expected result
is not weakened.
- Log the tablet metadata and the observed BE rowset metadata to make
any timeout diagnosable.
- Keep the later post-insert assertions synchronous so genuine
publish-visibility regressions are still detected.

### Release note

None

### Check List (For Author)

- Test:
- Regression test: `test_query_sys_rowsets` passed 50/50 consecutive
runs on an isolated local cluster using the existing branch-4.1 FE/BE
binaries.
- Groovy compilation: `FileSystemCompiler
regression-test/suites/query_p0/system/test_query_sys_rowsets.groovy`
passed.
    - Static check: `git diff --check` passed.
- Behavior changed: No
- Does this need documentation: No
@github-actions
github-actions Bot requested a review from yiguolei as a code owner August 5, 2026 01:20
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

run buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit 558c892 into branch-4.1 Aug 5, 2026
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants