Skip to content

[fix](be) Pin be exec version in segment test - #66465

Merged
csun5285 merged 1 commit into
apache:masterfrom
csun5285:fix/doris-27764-segment-golden-version
Aug 5, 2026
Merged

[fix](be) Pin be exec version in segment test#66465
csun5285 merged 1 commit into
apache:masterfrom
csun5285:fix/doris-27764-segment-golden-version

Conversation

@csun5285

@csun5285 csun5285 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Related PR: #65977#66112

SegmentFlusherFormatTest was added by #65977. Its BE UT pipeline ran before #66112 was merged and passed with BE exec version 10.

Release note

None

Check List (For Author)

  • Test: Unit Test
    • ./run-be-ut.sh --run --filter=SegmentFlusherFormatTest.ComplexObjectAndVariantValuesKeepTheirSegmentBytes -j 128
  • Behavior changed: No
  • Does this need documentation: No

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

### What problem does this PR solve?

Issue Number: None

Related PR: apache#65977

Problem Summary: The Segment golden test populated AGG_STATE metadata with the moving newest BE execution version. Golden files generated at version 10 failed byte comparison after the maximum version advanced to 11 even though the Segment payload format was unchanged. Pin the test schema to version 10, matching its checked-in golden footer, so unrelated future execution-version bumps do not invalidate the compatibility oracle.

### Release note

None

### Check List (For Author)

- Test: Unit Test
    - `./run-be-ut.sh --run --filter=SegmentFlusherFormatTest.ComplexObjectAndVariantValuesKeepTheirSegmentBytes -j 128`
- Behavior changed: No
- Does this need documentation: No
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285

csun5285 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@csun5285

csun5285 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@csun5285

csun5285 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Codex automated review failed and did not complete.

Error: All Codex review accounts are usage-limited; earliest retry is 2026-08-08T03:32:00Z.
Workflow run: https://github.com/apache/doris/actions/runs/30995312904

Please trigger /review again after that time.

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.74% (26037/43587)
Line Coverage 44.04% (263775/598970)
Region Coverage 39.81% (210197/527957)
Branch Coverage 41.21% (96135/233306)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.92% (32267/42503)
Line Coverage 60.74% (361351/594918)
Region Coverage 57.28% (303383/529695)
Branch Coverage 58.65% (136853/233330)

@csun5285

csun5285 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Codex automated review failed and did not complete.

Error: All Codex review accounts are usage-limited; earliest retry is 2026-08-08T03:32:00Z.
Workflow run: https://github.com/apache/doris/actions/runs/31011731908

Please trigger /review again after that time.

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 28956 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2e4e42c6e3e8123a629d267490727429b67e12ca, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17694	4098	3976	3976
q2	2021	330	209	209
q3	10279	1337	782	782
q4	4680	467	337	337
q5	7586	846	552	552
q6	182	173	134	134
q7	750	810	606	606
q8	9360	1659	1597	1597
q9	5884	4050	4033	4033
q10	6778	1612	1356	1356
q11	522	348	328	328
q12	727	567	458	458
q13	18096	3250	2748	2748
q14	270	257	240	240
q15	q16	735	729	655	655
q17	915	991	942	942
q18	6570	5601	5587	5587
q19	1283	1217	1105	1105
q20	857	710	586	586
q21	5894	2622	2427	2427
q22	432	350	298	298
Total cold run time: 101515 ms
Total hot run time: 28956 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4345	4238	4208	4208
q2	281	326	206	206
q3	4524	4924	4351	4351
q4	2161	2266	1399	1399
q5	4226	4092	4095	4092
q6	252	184	127	127
q7	1670	1569	1403	1403
q8	2705	2123	2089	2089
q9	7194	7231	7256	7231
q10	4271	4280	3882	3882
q11	573	401	370	370
q12	718	767	517	517
q13	3173	3562	2918	2918
q14	292	286	273	273
q15	q16	736	730	624	624
q17	1313	1315	1322	1315
q18	12206	11004	11861	11004
q19	1192	1166	1136	1136
q20	2232	2197	1965	1965
q21	5726	4974	4818	4818
q22	512	472	422	422
Total cold run time: 60302 ms
Total hot run time: 54350 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 167025 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2e4e42c6e3e8123a629d267490727429b67e12ca, data reload: false

query5	4318	588	460	460
query6	449	219	203	203
query7	4924	552	333	333
query8	337	163	147	147
query9	8771	4055	4056	4055
query10	473	368	292	292
query11	5838	2201	1991	1991
query12	152	97	95	95
query13	1248	579	437	437
query14	6094	4474	4139	4139
query14_1	3947	3987	3969	3969
query15	211	196	181	181
query16	988	477	468	468
query17	952	710	573	573
query18	2433	475	354	354
query19	214	191	152	152
query20	110	106	102	102
query21	237	169	143	143
query22	13062	12962	12817	12817
query23	15683	15015	14606	14606
query23_1	14713	14718	14660	14660
query24	7465	1742	1269	1269
query24_1	1262	1260	1287	1260
query25	578	451	380	380
query26	1314	362	219	219
query27	2599	564	361	361
query28	4552	2034	1992	1992
query29	1107	644	505	505
query30	348	263	224	224
query31	1180	1123	1088	1088
query32	123	65	61	61
query33	557	332	260	260
query34	1253	1140	637	637
query35	761	751	651	651
query36	789	817	742	742
query37	160	110	98	98
query38	1845	1778	1674	1674
query39	841	811	790	790
query39_1	797	778	805	778
query40	259	171	146	146
query41	72	69	69	69
query42	98	97	98	97
query43	324	340	286	286
query44	1483	769	773	769
query45	194	179	173	173
query46	1043	1212	728	728
query47	1544	1520	1431	1431
query48	412	420	338	338
query49	575	400	291	291
query50	1124	431	374	374
query51	10633	10803	10879	10803
query52	86	87	73	73
query53	257	287	199	199
query54	279	229	239	229
query55	74	72	65	65
query56	311	312	295	295
query57	1005	983	913	913
query58	268	261	258	258
query59	1540	1578	1397	1397
query60	316	271	259	259
query61	149	147	142	142
query62	398	315	266	266
query63	240	196	203	196
query64	2840	1033	828	828
query65	3899	3789	3805	3789
query66	1851	469	357	357
query67	27994	28119	27874	27874
query68	3262	1525	977	977
query69	414	303	262	262
query70	923	819	787	787
query71	387	318	312	312
query72	3093	2573	2266	2266
query73	820	810	447	447
query74	4671	4520	4301	4301
query75	2371	2309	1994	1994
query76	2296	1176	800	800
query77	361	374	280	280
query78	11083	11037	10632	10632
query79	1391	1111	729	729
query80	1274	539	456	456
query81	547	333	295	295
query82	643	178	137	137
query83	369	328	307	307
query84	333	163	134	134
query85	955	610	510	510
query86	403	242	223	223
query87	1997	1960	1841	1841
query88	3765	2817	2794	2794
query89	393	319	285	285
query90	1921	205	204	204
query91	204	199	159	159
query92	64	60	54	54
query93	1670	1538	1009	1009
query94	710	367	321	321
query95	792	622	490	490
query96	1056	790	351	351
query97	2456	2483	2338	2338
query98	193	187	185	185
query99	733	728	602	602
Total cold run time: 253537 ms
Total hot run time: 167025 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 23.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2e4e42c6e3e8123a629d267490727429b67e12ca, data reload: false

query1	0.00	0.00	0.01
query2	0.10	0.05	0.04
query3	0.26	0.15	0.13
query4	1.61	0.14	0.14
query5	0.24	0.23	0.22
query6	1.17	0.83	0.84
query7	0.04	0.01	0.01
query8	0.06	0.04	0.04
query9	0.38	0.31	0.31
query10	0.54	0.59	0.56
query11	0.19	0.15	0.13
query12	0.19	0.14	0.14
query13	0.46	0.46	0.46
query14	1.00	0.99	0.98
query15	0.59	0.56	0.58
query16	0.33	0.36	0.31
query17	1.08	1.08	1.08
query18	0.22	0.19	0.19
query19	2.09	1.94	1.91
query20	0.02	0.02	0.01
query21	15.45	0.23	0.14
query22	4.67	0.05	0.06
query23	16.15	0.31	0.12
query24	2.93	0.44	0.31
query25	0.10	0.06	0.05
query26	0.73	0.23	0.15
query27	0.05	0.03	0.03
query28	3.52	0.81	0.35
query29	12.47	4.02	3.14
query30	0.28	0.15	0.15
query31	2.77	0.54	0.31
query32	3.22	0.59	0.48
query33	3.20	3.28	3.16
query34	15.62	3.94	3.28
query35	3.25	3.23	3.24
query36	0.57	0.43	0.44
query37	0.08	0.07	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.03
query40	0.18	0.15	0.14
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 96.06 s
Total hot run time: 23.77 s

@csun5285
csun5285 merged commit 1c72e84 into apache:master Aug 5, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants