Skip to content

branch-4.1: [fix](topn) Handle empty rowid fetch RPC failures #66443 - #66522

Open
github-actions[bot] wants to merge 1 commit into
branch-4.1from
auto-pick-66443-branch-4.1
Open

branch-4.1: [fix](topn) Handle empty rowid fetch RPC failures #66443#66522
github-actions[bot] wants to merge 1 commit into
branch-4.1from
auto-pick-66443-branch-4.1

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #66443

@github-actions
github-actions Bot requested a review from yiguolei as a code owner August 6, 2026 03:52
@yiguolei

yiguolei commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

run buildall

Problem Summary: TopN lazy materialization sends reusable rowid-fetch
RPC requests to every target backend. A backend request can contain no
row IDs for a batch, but a transport failure for that no-op request
previously aborted the query. If such a failure left no response blocks,
response merging could also read a missing or stale response. Ignore
transport failures only when the request has no rows, clear reused
responses before dispatch, and skip deserialization for empty
per-relation requests. Requests containing rows and all backend-reported
errors still fail.

### Release note

Fix TopN lazy materialization queries that fail when an empty
rowid-fetch RPC encounters a transport error.
@yiguolei
yiguolei force-pushed the auto-pick-66443-branch-4.1 branch from aeed88d to ed660ae Compare August 7, 2026 01:04
@yiguolei

yiguolei commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (30/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.73% (30479/41341)
Line Coverage 57.68% (335272/581217)
Region Coverage 54.55% (278956/511401)
Branch Coverage 55.51% (124978/225161)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants