[improvement](fe) Reuse external scan tasks within a statement - #66530
Open
924060929 wants to merge 1 commit into
Open
[improvement](fe) Reuse external scan tasks within a statement#66530924060929 wants to merge 1 commit into
924060929 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
924060929
changed the title
924060929
changed the title
morrySnow
changed the title
924060929
changed the title
924060929
changed the title
924060929
changed the title
924060929
changed the title
924060929
changed the title
924060929
changed the title
924060929
force-pushed
the
fix/cir-21262-typed-scan-reuse-key
branch
from
August 6, 2026 07:04
141fd94 to
cc165ac
Compare
Contributor
Author
|
run buildall |
924060929
force-pushed
the
fix/cir-21262-typed-scan-reuse-key
branch
2 times, most recently
from
August 6, 2026 08:23
495ee54 to
ab618f7
Compare
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 29000 ms |
Contributor
TPC-DS: Total hot run time: 166728 ms |
Contributor
ClickBench: Total hot run time: 23.96 s |
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
|
Codex automated review failed and did not complete. Error: All Codex review accounts are usage-limited; earliest retry is 2026-08-08T03:32:00Z. Please trigger /review again after that time. |
morrySnow
reviewed
Aug 7, 2026
924060929
force-pushed
the
fix/cir-21262-typed-scan-reuse-key
branch
from
August 7, 2026 03:07
ab618f7 to
02b8284
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
|
Codex automated review failed and did not complete. Error: All Codex review accounts are usage-limited; earliest retry is 2026-08-08T03:32:00Z. Please trigger /review again after that time. |
Replace string-encoded cache keys with typed key classes that use
Java's equals/hashCode for comparison. All ConnectorExpression
implementations already carry structural equals, so every key field
— filter conjuncts, partition lists, option maps, file scopes — is
stored as its natural Java type (List, Map, ConnectorExpression)
rather than an encoded String.
Changes:
- ConnectorStatementScope SPI: computeIfAbsent(String) -> (Object)
- 4 connector ScanReuseKey classes: add equals/hashCode, use raw types
- ConnectorScanKeyUtils: canonicalize only filter flattening
- Remove String.join(",") aliasing bugs (4 sites)
- Deduplicate canonicalFilter/stableMapToString helpers
- Update all ConnectorStatementScope implementations for new signature
- Fix ConnectorStatementScopeImpl javadoc for re-entrancy contract
The rewrite replaces the fe-core ExternalScanTaskCache prototype
(branch fix/cir-21262-iceberg-split-reuse) with the connector-SPI
approach already on master-test, eliminating ~400 lines of duplicate
infrastructure.
924060929
force-pushed
the
fix/cir-21262-typed-scan-reuse-key
branch
from
August 7, 2026 09:36
02b8284 to
a008699
Compare
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 28767 ms |
Contributor
TPC-DS: Total hot run time: 159489 ms |
Contributor
ClickBench: Total hot run time: 23.88 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
Queries with repeated equivalent external-table relations independently plan the same remote files for every branch, duplicating connector metadata work. The connector SPI already provides statement-scoped memoization (ConnectorStatementScope) for metadata, but scan planning was not memoized — each duplicate relation re-planned through the connector SDK.
This change adds statement-scoped scan reuse to all four connectors. Each builds a typed key from the facts that affect its split set:
Equivalent scans reuse connector-native tasks within one statement execution. Iceberg streaming/lazy batch paths and transactional Hive paths remain uncached to preserve their memory and transaction semantics. Mutable Hudi/Hive scheduling objects are copied before use. ConnectorStatementScope.computeIfAbsent is widened from String to Object to accept typed keys directly.
Release note
Reuse equivalent Iceberg, Paimon, Hudi, and Hive scan-planning results within one statement execution.
Check List (For Author)