[fix](fe) give ConfField.description a single string in the streaming-job config - #66541
Merged
morningman merged 1 commit intoAug 6, 2026
Merged
Conversation
…-job config master does not compile. fe-common fails at Config.java:[1177,65] annotation value not of an allowable type apache#66342 retyped ConfigBase.ConfField.description() from String[] to String and rewrote all 419 call sites accordingly. apache#66238 landed shortly after with @ConfField(mutable = true, masterOnly = true, description = { "Minimum interval in seconds between snapshot offset persistence operations"}) written against the older String[] signature. The two are textually disjoint, so git merges them without a conflict and neither pull request could see the other: each was green on its own base. The seven further errors in the same module are secondary. The bad annotation value aborts the annotation-processing round, so lombok never contributes its generated members, and @slf4j's log plus @AllArgsConstructor/@DaTa's constructors go missing: DiskUtils.java:[70,13] cannot find symbol JobBaseConfig ... constructor cannot be applied to given types AbstractSourceSplit ... constructor cannot be applied to given types All seven disappear once the annotation value is fixed; nothing else in the tree needed a change. This is the only remaining array-form description in fe/ (grep -rnE 'description\s*=\s*\{'), and the wrapped-argument layout matches the neighbouring long descriptions such as max_create_table_timeout_second. ConfigTest.testConfFieldDescriptionsAreEnglishStrings, the guard apache#66342 added, reflects over the annotation at runtime and so cannot catch a compile-time signature mismatch; it passes here because the text is already English. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S73AWq9AHxYfKkzWJfTcKs
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
skip buildall |
hello-stephen
approved these changes
Aug 6, 2026
hubgeter
approved these changes
Aug 6, 2026
924060929
approved these changes
Aug 6, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #66342, #66238
Problem Summary:
master does not compile.
fe-commonfails at#66342 retyped
ConfigBase.ConfField.description()fromString[]toStringand rewrote all 419 call sites accordingly. #66238 landed shortly after withwritten against the older
String[]signature. The two changes are textually disjoint, so git merges them without a conflict and neither pull request could see the other — each was green on its own base.The seven further errors reported in the same module are secondary. The bad annotation value aborts the annotation-processing round, so lombok never contributes its generated members, and
@Slf4j'slogplus@AllArgsConstructor/@Data's constructors go missing:All seven disappear once the annotation value is fixed; nothing else in the tree needed a change.
This is the only remaining array-form description under
fe/(grep -rnE 'description\s*=\s*\{'), and the wrapped-argument layout matches the neighbouring long descriptions such asmax_create_table_timeout_second.ConfigTest.testConfFieldDescriptionsAreEnglishStrings, the guard #66342 added, reflects over the annotation at runtime, so it cannot catch a compile-time signature mismatch; it passes here because the text is already English.Verified on a clean checkout of master
4e3c1b84dd5:mvn test-compile(checkstyle included): 74/74 modules SUCCESSfe-commonmodule tests: 157 tests, 0 failures, 0 skipped, includingConfigTest.testConfFieldDescriptionsAreEnglishStringsStreamingInsertJobOffsetPersistenceTest,JdbcSourceOffsetProviderOffsetTest,SessionVariablesTest: 39 tests, 0 failures, 0 skippedRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?