[opt](merge into) Put MERGE INTO target on the probe side #66565
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.trees.plans.commands.merge; | ||
|
|
||
| import org.apache.doris.nereids.rules.exploration.join.JoinReorderContext; | ||
| import org.apache.doris.nereids.trees.expressions.Expression; | ||
| import org.apache.doris.nereids.trees.plans.JoinType; | ||
| import org.apache.doris.nereids.trees.plans.logical.LogicalJoin; | ||
| import org.apache.doris.nereids.trees.plans.logical.LogicalPlan; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
|
|
||
| /** | ||
| * Shared plan-construction helpers for MERGE INTO, used by both the internal OLAP path | ||
| * ({@link MergeIntoCommand}) and the external path | ||
| * ({@link org.apache.doris.nereids.trees.plans.commands.ExternalRowLevelMergePlanBuilder}). | ||
| */ | ||
| public class MergeUtils { | ||
|
|
||
| private MergeUtils() { | ||
| } | ||
|
|
||
| /** | ||
| * Build the base join between merge target and source, with the target on the LEFT (probe) | ||
| * side. Doris builds the hash table on the right child, and the target side is structurally | ||
| * the wide one: it must carry every table column plus the row identity for the sink, while | ||
| * the source usually only carries join keys and new values. Keeping the target on the probe | ||
|
Contributor
There was a problem hiding this comment. The Javadoc mentions that "Doris builds the hash table on the right child" — it would be helpful to also explicitly note that |
||
| * side also lets RuntimeFilterGenerator prune the target scan with runtime filters built | ||
| * from the source side: INNER and RIGHT_OUTER joins may produce runtime filters while | ||
| * LEFT_OUTER is in its denied list. | ||
| * | ||
| * <p>Unmatched source rows are only needed by WHEN NOT MATCHED clauses, so without them the | ||
| * join is INNER; with them, RIGHT OUTER preserves exactly the unmatched source rows, which | ||
| * is equivalent to the previous "source LEFT OUTER JOIN target" shape. | ||
| */ | ||
| public static LogicalPlan buildMergeJoin(LogicalPlan targetPlan, LogicalPlan source, | ||
| Expression onClause, boolean hasNotMatchedClauses) { | ||
| JoinType joinType = hasNotMatchedClauses ? JoinType.RIGHT_OUTER_JOIN : JoinType.INNER_JOIN; | ||
| return new LogicalJoin<>(joinType, | ||
| ImmutableList.of(), ImmutableList.of(onClause), | ||
| targetPlan, source, JoinReorderContext.EMPTY); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc mentions that "Doris builds the hash table on the right child" — it would be helpful to also explicitly note that (which excludes but allows and ) is a co-motivator for this choice. This makes the rationale self-contained for future readers who might wonder why RIGHT_OUTER was chosen over LEFT_OUTER.