Skip to content

[enhancement](variant) Support deep Variant object leaf projection - #66575

Open
Gabriel39 wants to merge 1 commit into
apache:branch-4.1from
Gabriel39:dev/variant-deep-object-leaf-projection-4.1
Open

[enhancement](variant) Support deep Variant object leaf projection#66575
Gabriel39 wants to merge 1 commit into
apache:branch-4.1from
Gabriel39:dev/variant-deep-object-leaf-projection-4.1

Conversation

@Gabriel39

@Gabriel39 Gabriel39 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary:

File Scanner V2 carried Variant access paths as a list of string segments, but the BE Parquet mapper only projected one top-level shredded leaf. Deep object paths therefore fell back even when every nested typed_value wrapper was physically available. The FE access-path comparator also joined segments with dots, so an object key such as a.b could collide with the nested path a/b before the paths reached BE.

This change reuses the existing access-path list without any Thrift or Proto change. It compares FE paths segment by segment, merges sibling and prefix paths through the shared BE access-path tree, and traverses arbitrary-depth object typed_value wrappers for Iceberg and Paimon native Parquet scans. Numeric segments, repeated ancestors, missing leaves, unshredded files, and ambiguous physical leaf identities conservatively fall back to the complete Variant root. Numeric array indexes remain unsupported with a TODO for typed path segments.

Release note

Support arbitrary-depth object-only Variant leaf projection for Iceberg and Paimon native Parquet scans.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes. Iceberg and Paimon native Parquet scans can physically project deeply shredded Variant object leaves while preserving conservative fallback behavior.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Gabriel39
Gabriel39 requested a review from yiguolei as a code owner August 7, 2026 08:10
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39

Copy link
Copy Markdown
Contributor Author

run buildall

@Gabriel39

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Codex automated review failed and did not complete.

Error: All Codex review accounts are usage-limited; earliest retry is 2026-08-08T03:32:00Z.
Workflow run: https://github.com/apache/doris/actions/runs/31160616690

Please trigger /review again after that time.

@Gabriel39
Gabriel39 force-pushed the dev/variant-deep-object-leaf-projection-4.1 branch from bd7fc68 to 4c8217f Compare August 7, 2026 08:42
@Gabriel39

Copy link
Copy Markdown
Contributor Author

run buildall

@Gabriel39

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Codex automated review failed and did not complete.

Error: All Codex review accounts are usage-limited; earliest retry is 2026-08-08T03:32:00Z.
Workflow run: https://github.com/apache/doris/actions/runs/31162925837

Please trigger /review again after that time.

@Gabriel39 Gabriel39 changed the title [Enhancement] Support deep Variant object leaf projection [enhancement](variant) Support deep Variant object leaf projection Aug 7, 2026
@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.79% (30529/41373)
Line Coverage 57.77% (336077/581714)
Region Coverage 54.63% (279612/511865)
Branch Coverage 55.58% (125296/225422)

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (11/11) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants